From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH] netfilter: xt_socket: fix broken v0 support
Date: Mon, 15 Jul 2013 20:20:21 +0200 [thread overview]
Message-ID: <20130715182021.GA12140@localhost> (raw)
In-Reply-To: <1373595739.4600.123.camel@edumazet-glaptop>
On Thu, Jul 11, 2013 at 07:22:19PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> commit 681f130f39e10 ("netfilter: xt_socket: add XT_SOCKET_NOWILDCARD
> flag") added a potential NULL dereference if an old iptables package
> uses v0 of the match.
>
> Fix this by removing the test on @info in fast path.
>
> IPv6 can remove the test as well, as it uses v1 or v2.
Applied, thanks Eric.
prev parent reply other threads:[~2013-07-15 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 2:22 [PATCH] netfilter: xt_socket: fix broken v0 support Eric Dumazet
2013-07-15 18:20 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715182021.GA12140@localhost \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.