From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: nohz: Warn if the machine can not perform nohz_full
Date: Mon, 15 Jul 2013 14:56:24 -0400 [thread overview]
Message-ID: <20130715185624.GB1706@redhat.com> (raw)
In-Reply-To: <1373914182.17876.165.camel@gandalf.local.home>
On Mon, Jul 15, 2013 at 02:49:42PM -0400, Steven Rostedt wrote:
> > And here's a Core Duo from circa 2008.
> > http://paste.fedoraproject.org/25429/13739098/raw
> >
> > Two for two so far. I get the feeling you guys are going to get a ton of these reports.
>
> Hmm, we should only warn if the user tried to enable nohz-full via the
> command line. But it looks like it warns even without enabling
> nohz-full, which wasn't the desired effect.
>
> I'll look at this, and send a patch to make sure the warning only
> happens when the user tries to use nohz-full, and doesn't just compile
> it in. The point of the patch is to not let the user think they have
> nohz-full when they don't.
Is a printk not enough for that purpose ? Tainting the kernel is kinda anti-social.
Dave
next prev parent reply other threads:[~2013-07-15 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 17:08 nohz: Warn if the machine can not perform nohz_full Dave Jones
2013-07-15 17:18 ` Frederic Weisbecker
2013-07-15 17:24 ` Dave Jones
2013-07-15 17:38 ` Dave Jones
2013-07-15 18:49 ` Steven Rostedt
2013-07-15 18:56 ` Dave Jones [this message]
2013-07-15 19:30 ` Steven Rostedt
2013-07-16 1:10 ` Frederic Weisbecker
2013-07-16 1:05 ` Frederic Weisbecker
2013-07-16 14:22 ` [PATCH] nohz: Do not warn about unstable tsc unless user uses nohz_full Steven Rostedt
2013-07-16 16:12 ` Frederic Weisbecker
2013-07-16 1:03 ` nohz: Warn if the machine can not perform nohz_full Frederic Weisbecker
2013-07-16 1:01 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715185624.GB1706@redhat.com \
--to=davej@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.