From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.free-electrons.com ([94.23.35.102]:35191 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753159Ab3GPMOj (ORCPT ); Tue, 16 Jul 2013 08:14:39 -0400 Date: Tue, 16 Jul 2013 09:14:33 -0300 From: Ezequiel Garcia To: Andrew Lunn Cc: Thomas Petazzoni , Lior Amsalem , linux-watchdog@vger.kernel.org, Arnd Bergmann , devicetree-discuss@lists.ozlabs.org, wim@iguana.be, Maen Suleiman , Gregory Clement , Jason Cooper , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH 00/10] Orion Watchdog fixes Message-ID: <20130716121432.GA2317@localhost> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> <20130716073101.GB25043@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130716073101.GB25043@lunn.ch> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable Hi Thomas, Andrew: Thanks for looking at this! On Tue, Jul 16, 2013 at 09:31:01AM +0200, Andrew Lunn wrote: > On Tue, Jul 16, 2013 at 09:20:59AM +0200, Thomas Petazzoni wrote: > >=20 > > On Tue, 16 Jul 2013 08:59:52 +0200, Andrew Lunn wrote: > >=20 > > > Maybe i'm missing something here. You are making use of > > > orion_timer_ctrl_clrset() from time-orion.c. How will this work on > > > 370/XP which has a different clocksource driver? > >=20 > > I *think* the idea is that the Armada 370/XP driver will expose the > > same function, so from the point of view of the watchdog driver, it > > will just work. Indeed that was one of the ideas. As Thomas said, this was just preparation work. >=20 > That was what i was thinking would happen. And then i started to > wonder how well the kernel linker deals with multiple definitions of > the same symbol. Dove and 370/XP can end up in the same kernel. So we > need to have both orion-timer and the 370/XP timer in the same kernel, > so we end up with the same symbol in the kernel twice... >=20 Yeah, well... I wasn't sure about using the same name, so another approac= h would be adding a new compatible to the driver and then make it use the appropriate function in the 370/XP clocksource driver (with a different n= ame). And, yet another approach, is what Sebastian just said, although I'm not sure I understood it :). In any case, we have already several solutio= ns, which is why I'm not too worried about this particular issue. On the other side, I'm much interested in knowing if you are OK with breaking the watchdog DT compatibility. If you NACK this, then I'll start preparing a different watchdog driver for 370/XP, since I don't want to extend a driver that is a bit dirty. --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 16 Jul 2013 09:14:33 -0300 Subject: [PATCH 00/10] Orion Watchdog fixes In-Reply-To: <20130716073101.GB25043@lunn.ch> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> <20130716073101.GB25043@lunn.ch> Message-ID: <20130716121432.GA2317@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thomas, Andrew: Thanks for looking at this! On Tue, Jul 16, 2013 at 09:31:01AM +0200, Andrew Lunn wrote: > On Tue, Jul 16, 2013 at 09:20:59AM +0200, Thomas Petazzoni wrote: > > > > On Tue, 16 Jul 2013 08:59:52 +0200, Andrew Lunn wrote: > > > > > Maybe i'm missing something here. You are making use of > > > orion_timer_ctrl_clrset() from time-orion.c. How will this work on > > > 370/XP which has a different clocksource driver? > > > > I *think* the idea is that the Armada 370/XP driver will expose the > > same function, so from the point of view of the watchdog driver, it > > will just work. Indeed that was one of the ideas. As Thomas said, this was just preparation work. > > That was what i was thinking would happen. And then i started to > wonder how well the kernel linker deals with multiple definitions of > the same symbol. Dove and 370/XP can end up in the same kernel. So we > need to have both orion-timer and the 370/XP timer in the same kernel, > so we end up with the same symbol in the kernel twice... > Yeah, well... I wasn't sure about using the same name, so another approach would be adding a new compatible to the driver and then make it use the appropriate function in the 370/XP clocksource driver (with a different name). And, yet another approach, is what Sebastian just said, although I'm not sure I understood it :). In any case, we have already several solutions, which is why I'm not too worried about this particular issue. On the other side, I'm much interested in knowing if you are OK with breaking the watchdog DT compatibility. If you NACK this, then I'll start preparing a different watchdog driver for 370/XP, since I don't want to extend a driver that is a bit dirty. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 00/10] Orion Watchdog fixes Date: Tue, 16 Jul 2013 09:14:33 -0300 Message-ID: <20130716121432.GA2317@localhost> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> <20130716073101.GB25043@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130716073101.GB25043-g2DYL2Zd6BY@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Andrew Lunn Cc: Lior Amsalem , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Maen Suleiman , wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper List-Id: devicetree@vger.kernel.org SGkgVGhvbWFzLCBBbmRyZXc6CgpUaGFua3MgZm9yIGxvb2tpbmcgYXQgdGhpcyEKCk9uIFR1ZSwg SnVsIDE2LCAyMDEzIGF0IDA5OjMxOjAxQU0gKzAyMDAsIEFuZHJldyBMdW5uIHdyb3RlOgo+IE9u IFR1ZSwgSnVsIDE2LCAyMDEzIGF0IDA5OjIwOjU5QU0gKzAyMDAsIFRob21hcyBQZXRhenpvbmkg d3JvdGU6Cj4gPiAKPiA+IE9uIFR1ZSwgMTYgSnVsIDIwMTMgMDg6NTk6NTIgKzAyMDAsIEFuZHJl dyBMdW5uIHdyb3RlOgo+ID4gCj4gPiA+IE1heWJlIGknbSBtaXNzaW5nIHNvbWV0aGluZyBoZXJl LiBZb3UgYXJlIG1ha2luZyB1c2Ugb2YKPiA+ID4gb3Jpb25fdGltZXJfY3RybF9jbHJzZXQoKSBm cm9tIHRpbWUtb3Jpb24uYy4gSG93IHdpbGwgdGhpcyB3b3JrIG9uCj4gPiA+IDM3MC9YUCB3aGlj aCBoYXMgYSBkaWZmZXJlbnQgY2xvY2tzb3VyY2UgZHJpdmVyPwo+ID4gCj4gPiBJICp0aGluayog dGhlIGlkZWEgaXMgdGhhdCB0aGUgQXJtYWRhIDM3MC9YUCBkcml2ZXIgd2lsbCBleHBvc2UgdGhl Cj4gPiBzYW1lIGZ1bmN0aW9uLCBzbyBmcm9tIHRoZSBwb2ludCBvZiB2aWV3IG9mIHRoZSB3YXRj aGRvZyBkcml2ZXIsIGl0Cj4gPiB3aWxsIGp1c3Qgd29yay4KCkluZGVlZCB0aGF0IHdhcyBvbmUg b2YgdGhlIGlkZWFzLiBBcyBUaG9tYXMgc2FpZCwgdGhpcyB3YXMganVzdApwcmVwYXJhdGlvbiB3 b3JrLgoKPiAKPiBUaGF0IHdhcyB3aGF0IGkgd2FzIHRoaW5raW5nIHdvdWxkIGhhcHBlbi4gQW5k IHRoZW4gaSBzdGFydGVkIHRvCj4gd29uZGVyIGhvdyB3ZWxsIHRoZSBrZXJuZWwgbGlua2VyIGRl YWxzIHdpdGggbXVsdGlwbGUgZGVmaW5pdGlvbnMgb2YKPiB0aGUgc2FtZSBzeW1ib2wuIERvdmUg YW5kIDM3MC9YUCBjYW4gZW5kIHVwIGluIHRoZSBzYW1lIGtlcm5lbC4gU28gd2UKPiBuZWVkIHRv IGhhdmUgYm90aCBvcmlvbi10aW1lciBhbmQgdGhlIDM3MC9YUCB0aW1lciBpbiB0aGUgc2FtZSBr ZXJuZWwsCj4gc28gd2UgZW5kIHVwIHdpdGggdGhlIHNhbWUgc3ltYm9sIGluIHRoZSBrZXJuZWwg dHdpY2UuLi4KPiAKClllYWgsIHdlbGwuLi4gSSB3YXNuJ3Qgc3VyZSBhYm91dCB1c2luZyB0aGUg c2FtZSBuYW1lLCBzbyBhbm90aGVyIGFwcHJvYWNoCndvdWxkIGJlIGFkZGluZyBhIG5ldyBjb21w YXRpYmxlIHRvIHRoZSBkcml2ZXIgYW5kIHRoZW4gbWFrZSBpdCB1c2UgdGhlCmFwcHJvcHJpYXRl IGZ1bmN0aW9uIGluIHRoZSAzNzAvWFAgY2xvY2tzb3VyY2UgZHJpdmVyICh3aXRoIGEgZGlmZmVy ZW50IG5hbWUpLgoKQW5kLCB5ZXQgYW5vdGhlciBhcHByb2FjaCwgaXMgd2hhdCBTZWJhc3RpYW4g anVzdCBzYWlkLCBhbHRob3VnaCBJJ20Kbm90IHN1cmUgSSB1bmRlcnN0b29kIGl0IDopLiBJbiBh bnkgY2FzZSwgd2UgaGF2ZSBhbHJlYWR5IHNldmVyYWwgc29sdXRpb25zLAp3aGljaCBpcyB3aHkg SSdtIG5vdCB0b28gd29ycmllZCBhYm91dCB0aGlzIHBhcnRpY3VsYXIgaXNzdWUuCgpPbiB0aGUg b3RoZXIgc2lkZSwgSSdtIG11Y2ggaW50ZXJlc3RlZCBpbiBrbm93aW5nIGlmIHlvdSBhcmUgT0sg d2l0aApicmVha2luZyB0aGUgd2F0Y2hkb2cgRFQgY29tcGF0aWJpbGl0eS4gSWYgeW91IE5BQ0sg dGhpcywgdGhlbiBJJ2xsCnN0YXJ0IHByZXBhcmluZyBhIGRpZmZlcmVudCB3YXRjaGRvZyBkcml2 ZXIgZm9yIDM3MC9YUCwgc2luY2UgSSBkb24ndAp3YW50IHRvIGV4dGVuZCBhIGRyaXZlciB0aGF0 IGlzIGEgYml0IGRpcnR5LgoKLS0gCkV6ZXF1aWVsIEdhcmPDrWEsIEZyZWUgRWxlY3Ryb25zCkVt YmVkZGVkIExpbnV4LCBLZXJuZWwgYW5kIEFuZHJvaWQgRW5naW5lZXJpbmcKaHR0cDovL2ZyZWUt ZWxlY3Ryb25zLmNvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0Bs aXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0 cmVlLWRpc2N1c3MK