From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.free-electrons.com ([94.23.35.102]:36000 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254Ab3GPOEk (ORCPT ); Tue, 16 Jul 2013 10:04:40 -0400 Date: Tue, 16 Jul 2013 11:04:36 -0300 From: Ezequiel Garcia To: Jason Cooper Cc: Andrew Lunn , Thomas Petazzoni , Lior Amsalem , linux-watchdog@vger.kernel.org, Arnd Bergmann , devicetree-discuss@lists.ozlabs.org, wim@iguana.be, Maen Suleiman , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH 00/10] Orion Watchdog fixes Message-ID: <20130716140435.GA23904@localhost> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> <20130716073101.GB25043@lunn.ch> <20130716121432.GA2317@localhost> <20130716134422.GE12062@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130716134422.GE12062@titan.lakedaemon.net> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2013 at 09:44:22AM -0400, Jason Cooper wrote: > On Tue, Jul 16, 2013 at 09:14:33AM -0300, Ezequiel Garcia wrote: > > On the other side, I'm much interested in knowing if you are OK with > > breaking the watchdog DT compatibility. If you NACK this, then I'll > > start preparing a different watchdog driver for 370/XP, since I don't > > want to extend a driver that is a bit dirty. >=20 > Apparently there is some agreement that the bindings are still in flux > and that they need to be for a bit longer in order to hammer out > problems such as this. >=20 > Arnd and Olof both mentioned that something (a doc, and email?) is > forthcoming about marking some bindings as stable. Whatever form that > takes, this one wouldn't get the stable marking yet. ;-) >=20 Yup, that's my understanding as well. But on the other side, I don't want to break possible users out there. So, just to check, you say it's early enough to safely do such change? In that case, I'll extend this patchset to include Armada 370/XP support and post it as soon as Sebastian's clocksource stuff gets in. > Oh, and one more nit. The work 'fix' triggers a whole bunch of "get on > this right away, does it need to go to stable? Has anyone confirmed it= ? > Which commit caused the regression? etc." Although I hate the word, I > think 'refactoring' is much more appropriate description for this serie= s. >=20 Oh, good observation. I wrote the cover letter at 8 PM, after ten long hours (*) of hacking and smashing this into something easy to review, and that's the best title I could come up with. I'll change it on v2. Thanks, (*) yes, I have another pair of eyes, in case these wear out. --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 16 Jul 2013 11:04:36 -0300 Subject: [PATCH 00/10] Orion Watchdog fixes In-Reply-To: <20130716134422.GE12062@titan.lakedaemon.net> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> <20130716073101.GB25043@lunn.ch> <20130716121432.GA2317@localhost> <20130716134422.GE12062@titan.lakedaemon.net> Message-ID: <20130716140435.GA23904@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 16, 2013 at 09:44:22AM -0400, Jason Cooper wrote: > On Tue, Jul 16, 2013 at 09:14:33AM -0300, Ezequiel Garcia wrote: > > On the other side, I'm much interested in knowing if you are OK with > > breaking the watchdog DT compatibility. If you NACK this, then I'll > > start preparing a different watchdog driver for 370/XP, since I don't > > want to extend a driver that is a bit dirty. > > Apparently there is some agreement that the bindings are still in flux > and that they need to be for a bit longer in order to hammer out > problems such as this. > > Arnd and Olof both mentioned that something (a doc, and email?) is > forthcoming about marking some bindings as stable. Whatever form that > takes, this one wouldn't get the stable marking yet. ;-) > Yup, that's my understanding as well. But on the other side, I don't want to break possible users out there. So, just to check, you say it's early enough to safely do such change? In that case, I'll extend this patchset to include Armada 370/XP support and post it as soon as Sebastian's clocksource stuff gets in. > Oh, and one more nit. The work 'fix' triggers a whole bunch of "get on > this right away, does it need to go to stable? Has anyone confirmed it? > Which commit caused the regression? etc." Although I hate the word, I > think 'refactoring' is much more appropriate description for this series. > Oh, good observation. I wrote the cover letter at 8 PM, after ten long hours (*) of hacking and smashing this into something easy to review, and that's the best title I could come up with. I'll change it on v2. Thanks, (*) yes, I have another pair of eyes, in case these wear out. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 00/10] Orion Watchdog fixes Date: Tue, 16 Jul 2013 11:04:36 -0300 Message-ID: <20130716140435.GA23904@localhost> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> <20130716073101.GB25043@lunn.ch> <20130716121432.GA2317@localhost> <20130716134422.GE12062@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130716134422.GE12062-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jason Cooper Cc: Andrew Lunn , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Maen Suleiman , Lior Amsalem , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org T24gVHVlLCBKdWwgMTYsIDIwMTMgYXQgMDk6NDQ6MjJBTSAtMDQwMCwgSmFzb24gQ29vcGVyIHdy b3RlOgo+IE9uIFR1ZSwgSnVsIDE2LCAyMDEzIGF0IDA5OjE0OjMzQU0gLTAzMDAsIEV6ZXF1aWVs IEdhcmNpYSB3cm90ZToKPiA+IE9uIHRoZSBvdGhlciBzaWRlLCBJJ20gbXVjaCBpbnRlcmVzdGVk IGluIGtub3dpbmcgaWYgeW91IGFyZSBPSyB3aXRoCj4gPiBicmVha2luZyB0aGUgd2F0Y2hkb2cg RFQgY29tcGF0aWJpbGl0eS4gSWYgeW91IE5BQ0sgdGhpcywgdGhlbiBJJ2xsCj4gPiBzdGFydCBw cmVwYXJpbmcgYSBkaWZmZXJlbnQgd2F0Y2hkb2cgZHJpdmVyIGZvciAzNzAvWFAsIHNpbmNlIEkg ZG9uJ3QKPiA+IHdhbnQgdG8gZXh0ZW5kIGEgZHJpdmVyIHRoYXQgaXMgYSBiaXQgZGlydHkuCj4g Cj4gQXBwYXJlbnRseSB0aGVyZSBpcyBzb21lIGFncmVlbWVudCB0aGF0IHRoZSBiaW5kaW5ncyBh cmUgc3RpbGwgaW4gZmx1eAo+IGFuZCB0aGF0IHRoZXkgbmVlZCB0byBiZSBmb3IgYSBiaXQgbG9u Z2VyIGluIG9yZGVyIHRvIGhhbW1lciBvdXQKPiBwcm9ibGVtcyBzdWNoIGFzIHRoaXMuCj4gCj4g QXJuZCBhbmQgT2xvZiBib3RoIG1lbnRpb25lZCB0aGF0IHNvbWV0aGluZyAoYSBkb2MsIGFuZCBl bWFpbD8pIGlzCj4gZm9ydGhjb21pbmcgYWJvdXQgbWFya2luZyBzb21lIGJpbmRpbmdzIGFzIHN0 YWJsZS4gIFdoYXRldmVyIGZvcm0gdGhhdAo+IHRha2VzLCB0aGlzIG9uZSB3b3VsZG4ndCBnZXQg dGhlIHN0YWJsZSBtYXJraW5nIHlldC4gOy0pCj4gCgpZdXAsIHRoYXQncyBteSB1bmRlcnN0YW5k aW5nIGFzIHdlbGwuIEJ1dCBvbiB0aGUgb3RoZXIgc2lkZSwgSSBkb24ndAp3YW50IHRvIGJyZWFr IHBvc3NpYmxlIHVzZXJzIG91dCB0aGVyZS4KClNvLCBqdXN0IHRvIGNoZWNrLCB5b3Ugc2F5IGl0 J3MgZWFybHkgZW5vdWdoIHRvIHNhZmVseSBkbyBzdWNoIGNoYW5nZT8KCkluIHRoYXQgY2FzZSwg SSdsbCBleHRlbmQgdGhpcyBwYXRjaHNldCB0byBpbmNsdWRlIEFybWFkYSAzNzAvWFAgc3VwcG9y dAphbmQgcG9zdCBpdCBhcyBzb29uIGFzIFNlYmFzdGlhbidzIGNsb2Nrc291cmNlIHN0dWZmIGdl dHMgaW4uCgo+IE9oLCBhbmQgb25lIG1vcmUgbml0LiAgVGhlIHdvcmsgJ2ZpeCcgdHJpZ2dlcnMg YSB3aG9sZSBidW5jaCBvZiAiZ2V0IG9uCj4gdGhpcyByaWdodCBhd2F5LCBkb2VzIGl0IG5lZWQg dG8gZ28gdG8gc3RhYmxlPyAgSGFzIGFueW9uZSBjb25maXJtZWQgaXQ/Cj4gV2hpY2ggY29tbWl0 IGNhdXNlZCB0aGUgcmVncmVzc2lvbj8gZXRjLiIgIEFsdGhvdWdoIEkgaGF0ZSB0aGUgd29yZCwg SQo+IHRoaW5rICdyZWZhY3RvcmluZycgaXMgbXVjaCBtb3JlIGFwcHJvcHJpYXRlIGRlc2NyaXB0 aW9uIGZvciB0aGlzIHNlcmllcy4KPiAKCk9oLCBnb29kIG9ic2VydmF0aW9uLiBJIHdyb3RlIHRo ZSBjb3ZlciBsZXR0ZXIgYXQgOCBQTSwgYWZ0ZXIgdGVuIGxvbmcKaG91cnMgKCopIG9mIGhhY2tp bmcgYW5kIHNtYXNoaW5nIHRoaXMgaW50byBzb21ldGhpbmcgZWFzeSB0byByZXZpZXcsCmFuZCB0 aGF0J3MgdGhlIGJlc3QgdGl0bGUgSSBjb3VsZCBjb21lIHVwIHdpdGguIEknbGwgY2hhbmdlIGl0 IG9uIHYyLgoKVGhhbmtzLAoKKCopIHllcywgSSBoYXZlIGFub3RoZXIgcGFpciBvZiBleWVzLCBp biBjYXNlIHRoZXNlIHdlYXIgb3V0LgotLSAKRXplcXVpZWwgR2FyY8OtYSwgRnJlZSBFbGVjdHJv bnMKRW1iZWRkZWQgTGludXgsIEtlcm5lbCBhbmQgQW5kcm9pZCBFbmdpbmVlcmluZwpodHRwOi8v ZnJlZS1lbGVjdHJvbnMuY29tCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNj dXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2Rl dmljZXRyZWUtZGlzY3Vzcwo=