All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3 02/14] arch: Refactor BR2_SOFT_FLOAT into per-architecture options
Date: Tue, 16 Jul 2013 14:12:31 +0200	[thread overview]
Message-ID: <20130716141231.57cada44@skate> (raw)
In-Reply-To: <874nbu3elx.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Tue, 16 Jul 2013 13:53:46 +0200, Peter Korsgaard wrote:

>  Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>  Thomas> ---
>  Thomas>  arch/Config.in                |  3 +++
>  Thomas>  arch/Config.in.arm            | 10 ++++++++++
>  Thomas>  arch/Config.in.mips           | 10 ++++++++++
>  Thomas>  arch/Config.in.powerpc        |  9 +++++++++
> 
> What about arc/avr32/bfin/microblaze/sh/sparc/xtensa? Some of them
> apparently were broken in this regard already, and some of them are not
> supported by the internal toolchain, but with this change atleast
> Buildroot will always think they use hardfloat.

avr32 already selects BR2_SOFT_FLOAT in the current git master.

config BR2_avr32
        bool "AVR32"
        select BR2_SOFT_FLOAT

On the other platforms you mentioned, BR2_SOFT_FLOAT was always false:

config BR2_SOFT_FLOAT
        bool "Use software floating point by default"
        depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_mips || BR2_mipsel || BR2_powerpc

which explains why I didn't take care of any of them. I honestly have
no idea for those platforms which ones do soft-float, which ones do
hard-float. It already took me a while to get a minimal understanding
of how things work in the ARM world in terms of floating point
support :)

From the perspective of those architectures, the BR2_SOFT_FLOAT value
was always false, and continues to be false after my patches. If this
is not correct, it should certainly be fixed, but I don't think this is
something that gets broken by my patches: it would have already been
wrong, and the Buildroot code already believes those architectures are
all hard float.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-07-16 12:12 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16  8:03 [Buildroot] [PATCHv3 00/14] ARM floating point improvements, EABIhf and Thumb2 support Thomas Petazzoni
2013-07-16  8:03 ` [Buildroot] [PATCHv3 01/14] arch: introduce BR2_GCC_TARGET_{FPU, FLOAT_ABI} Thomas Petazzoni
2013-07-16 11:48   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 02/14] arch: Refactor BR2_SOFT_FLOAT into per-architecture options Thomas Petazzoni
2013-07-16 11:53   ` Peter Korsgaard
2013-07-16 12:12     ` Thomas Petazzoni [this message]
2013-07-16 12:34       ` Peter Korsgaard
2013-07-16 13:12   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 03/14] arch: improve ARM floating point support and add support for EABIhf Thomas Petazzoni
2013-07-16 13:12   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 04/14] binutils: exclude binutils versions that don't support EABIhf Thomas Petazzoni
2013-07-16 13:12   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 05/14] gcc: take into account ARM floating point capabilities Thomas Petazzoni
2013-07-16 13:13   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 06/14] toolchain: remove the old BR2_VFP_FLOAT option Thomas Petazzoni
2013-07-16 13:15   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 07/14] configs: update defconfigs after VFP option changes Thomas Petazzoni
2013-07-16 13:16   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 08/14] configs: use new EABIhf option for beaglebone_defconfig Thomas Petazzoni
2013-07-16 13:19   ` Peter Korsgaard
2013-07-16 13:32     ` Thomas Petazzoni
2013-07-16 13:39       ` Peter Korsgaard
2013-07-16 13:47         ` Thomas Petazzoni
2013-07-16 15:06           ` Spenser Gilliland
2013-07-16 15:23             ` Thomas Petazzoni
2013-07-16 15:31             ` Peter Korsgaard
2013-07-16 13:39   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 09/14] toolchain-external: update config options after EABIhf introduction Thomas Petazzoni
2013-07-16 13:21   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 10/14] gcc: create symbolic link to ld-linux in EABIhf/gcc 4.7/eglibc Thomas Petazzoni
2013-07-16 13:23   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 11/14] arch/arm: add support for Thumb2 Thomas Petazzoni
2013-07-16 13:29   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 12/14] uclibc: use numbered patches for 0.9.33.2 Thomas Petazzoni
2013-07-16 13:31   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 13/14] uclibc: add Thumb2 fixes Thomas Petazzoni
2013-07-16 13:32   ` Peter Korsgaard
2013-07-16  8:03 ` [Buildroot] [PATCHv3 14/14] arch: use tabs instead of spaces in Config.in files Thomas Petazzoni
2013-07-16 13:32   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130716141231.57cada44@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.