From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.free-electrons.com ([94.23.35.102]:36119 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183Ab3GPOSz (ORCPT ); Tue, 16 Jul 2013 10:18:55 -0400 Date: Tue, 16 Jul 2013 11:18:51 -0300 From: Ezequiel Garcia To: Andrew Lunn Cc: linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-watchdog@vger.kernel.org, Jason Cooper , Sebastian Hesselbarth , Arnd Bergmann , Lior Amsalem , Maen Suleiman , Thomas Petazzoni , Gregory Clement , wim@iguana.be Subject: Re: [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register Message-ID: <20130716141850.GB23904@localhost> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <1373931163-12670-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130716140415.GB19448@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130716140415.GB19448@lunn.ch> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable Andrew, On Tue, Jul 16, 2013 at 04:04:15PM +0200, Andrew Lunn wrote: > On Mon, Jul 15, 2013 at 08:32:38PM -0300, Ezequiel Garcia wrote: > > Instead of accessing the RSTOUT register directly, this commit > > adds a platform memory resource to map this register into the driver. >=20 >=20 > Have you looked at: >=20 > arch/arm/mach-mvebu/system-controller.c >=20 Mmm... I saw the use of the RSTOUT register in kirkwood_restart() but wasn't sure who should be the real 'owner' of this register. > It is also using this register. Are we going to have a similar problem > as the TIMER_CTRL register, which you refactered in an earlier patch? >=20 Probably. > "marvell,orion-system-controller" is not actually used yet, but once > kirkwood moves into mach-mvebu, it will start using it. >=20 I guess so. We should take that into account *now*. Let me think about it and see if I can have something sane for v2. Thanks! --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 16 Jul 2013 11:18:51 -0300 Subject: [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register In-Reply-To: <20130716140415.GB19448@lunn.ch> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <1373931163-12670-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130716140415.GB19448@lunn.ch> Message-ID: <20130716141850.GB23904@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Andrew, On Tue, Jul 16, 2013 at 04:04:15PM +0200, Andrew Lunn wrote: > On Mon, Jul 15, 2013 at 08:32:38PM -0300, Ezequiel Garcia wrote: > > Instead of accessing the RSTOUT register directly, this commit > > adds a platform memory resource to map this register into the driver. > > > Have you looked at: > > arch/arm/mach-mvebu/system-controller.c > Mmm... I saw the use of the RSTOUT register in kirkwood_restart() but wasn't sure who should be the real 'owner' of this register. > It is also using this register. Are we going to have a similar problem > as the TIMER_CTRL register, which you refactered in an earlier patch? > Probably. > "marvell,orion-system-controller" is not actually used yet, but once > kirkwood moves into mach-mvebu, it will start using it. > I guess so. We should take that into account *now*. Let me think about it and see if I can have something sane for v2. Thanks! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register Date: Tue, 16 Jul 2013 11:18:51 -0300 Message-ID: <20130716141850.GB23904@localhost> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <1373931163-12670-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130716140415.GB19448@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130716140415.GB19448-g2DYL2Zd6BY@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Andrew Lunn Cc: Lior Amsalem , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Maen Suleiman , wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Jason Cooper , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org QW5kcmV3LAoKT24gVHVlLCBKdWwgMTYsIDIwMTMgYXQgMDQ6MDQ6MTVQTSArMDIwMCwgQW5kcmV3 IEx1bm4gd3JvdGU6Cj4gT24gTW9uLCBKdWwgMTUsIDIwMTMgYXQgMDg6MzI6MzhQTSAtMDMwMCwg RXplcXVpZWwgR2FyY2lhIHdyb3RlOgo+ID4gSW5zdGVhZCBvZiBhY2Nlc3NpbmcgdGhlIFJTVE9V VCByZWdpc3RlciBkaXJlY3RseSwgdGhpcyBjb21taXQKPiA+IGFkZHMgYSBwbGF0Zm9ybSBtZW1v cnkgcmVzb3VyY2UgdG8gbWFwIHRoaXMgcmVnaXN0ZXIgaW50byB0aGUgZHJpdmVyLgo+IAo+IAo+ IEhhdmUgeW91IGxvb2tlZCBhdDoKPiAKPiBhcmNoL2FybS9tYWNoLW12ZWJ1L3N5c3RlbS1jb250 cm9sbGVyLmMKPiAKCk1tbS4uLiBJIHNhdyB0aGUgdXNlIG9mIHRoZSBSU1RPVVQgcmVnaXN0ZXIg aW4ga2lya3dvb2RfcmVzdGFydCgpCmJ1dCB3YXNuJ3Qgc3VyZSB3aG8gc2hvdWxkIGJlIHRoZSBy ZWFsICdvd25lcicgb2YgdGhpcyByZWdpc3Rlci4KCj4gSXQgaXMgYWxzbyB1c2luZyB0aGlzIHJl Z2lzdGVyLiBBcmUgd2UgZ29pbmcgdG8gaGF2ZSBhIHNpbWlsYXIgcHJvYmxlbQo+IGFzIHRoZSBU SU1FUl9DVFJMIHJlZ2lzdGVyLCB3aGljaCB5b3UgcmVmYWN0ZXJlZCBpbiBhbiBlYXJsaWVyIHBh dGNoPwo+IAoKUHJvYmFibHkuCgo+ICJtYXJ2ZWxsLG9yaW9uLXN5c3RlbS1jb250cm9sbGVyIiBp cyBub3QgYWN0dWFsbHkgdXNlZCB5ZXQsIGJ1dCBvbmNlCj4ga2lya3dvb2QgbW92ZXMgaW50byBt YWNoLW12ZWJ1LCBpdCB3aWxsIHN0YXJ0IHVzaW5nIGl0Lgo+IAoKSSBndWVzcyBzby4gV2Ugc2hv dWxkIHRha2UgdGhhdCBpbnRvIGFjY291bnQgKm5vdyouIExldCBtZSB0aGluayBhYm91dAppdCBh bmQgc2VlIGlmIEkgY2FuIGhhdmUgc29tZXRoaW5nIHNhbmUgZm9yIHYyLgoKVGhhbmtzIQotLSAK RXplcXVpZWwgR2FyY8OtYSwgRnJlZSBFbGVjdHJvbnMKRW1iZWRkZWQgTGludXgsIEtlcm5lbCBh bmQgQW5kcm9pZCBFbmdpbmVlcmluZwpodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3Vz cyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6 Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2RldmljZXRyZWUtZGlzY3Vzcwo=