From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45383)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1UzDyD-00076M-Bt
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 18:43:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1UzDyC-0008SJ-Hv
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 18:43:45 -0400
Received: from nodalink.pck.nerim.net ([62.212.105.220]:44688
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1UzDyC-0008S6-88
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 18:43:44 -0400
Date: Wed, 17 Jul 2013 00:45:30 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130716224530.GB5102@irqsave.net>
References: <1371738392-9594-1-git-send-email-benoit@irqsave.net>
	<1371738392-9594-2-git-send-email-benoit@irqsave.net>
	<20130702144224.GF9870@stefanha-thinkpad.redhat.com>
	<20130702212355.GB4985@irqsave.net>
	<20130703081235.GD16585@stefanha-thinkpad.muc.redhat.com>
	<20130703125327.GC5482@irqsave.net>
	<20130704071300.GA2584@stefanha-thinkpad.redhat.com>
	<20130704100128.GA5429@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20130704100128.GA5429@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

> > Simple is good.  Even for deduplication alone, I think data integrity=
 is
> > critical - otherwise we risk stale dedup metadata pointing to cluster=
s
> > that are unallocated or do not contain the right data.  So the journa=
l
> > will probably need to follow techniques for commits/checksums.
>

I'll add checksums to the journal and clean the journal entry size mess s=
oon.

For the transactional/commits aspect of the journal I think that we need =
Kevin's
point of view on the subject.

Best regards

Beno=EEt