All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Valentina Manea <valentina.manea.m@gmail.com>, bhelgaas@google.com
Cc: linux-kernel@vger.kernel.org, bin.gao@linux.intel.com,
	gregkh@linuxfoundation.org, bhelgaas@google.com, x86@kernel.org,
	hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH v2] x86/pci: checkpatch.pl cleanup
Date: Wed, 17 Jul 2013 09:58:13 +0200	[thread overview]
Message-ID: <20130717075813.GA14629@gmail.com> (raw)
In-Reply-To: <1373874048-20258-1-git-send-email-valentina.manea.m@gmail.com>


* Valentina Manea <valentina.manea.m@gmail.com> wrote:

> This patch fixes warning and errors found by checkpatch.pl:
> 
> * replace asm/acpi.h, asm/io.h and asm/smp.h with linux/acpi.h,
> linux/io.h and linux/smp.h respectively
> * remove explicit initialization to 0 of a static global variable
> * replace printk(KERN_INFO ...) with pr_info
> * use tabs instead of spaces for indentation
> * arrange comments so that they adhere to Documentation/CodingStyle
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>

Looks good, thanks.

Bjorn, I can pick this up into tip:x86/cleanups, or would you like to put 
this into the PCI tree?

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  reply	other threads:[~2013-07-17  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  7:40 [PATCH v2] x86/pci: checkpatch.pl cleanup Valentina Manea
2013-07-17  7:58 ` Ingo Molnar [this message]
2013-07-19 21:25   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717075813.GA14629@gmail.com \
    --to=mingo@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bin.gao@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=valentina.manea.m@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.