All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 1/2] mfd: wm8994: Remove duplicate check for active JACKDET
Date: Wed, 17 Jul 2013 12:52:49 +0100	[thread overview]
Message-ID: <20130717115249.GE3336@laptop> (raw)
In-Reply-To: <1374060037-18527-1-git-send-email-broonie@kernel.org>

On Wed, 17 Jul 2013, Mark Brown wrote:

> From: Mark Brown <broonie@linaro.org>
> 
> Probably the result of a mismerge or rebase failing to notice that the
> hunk had already been applied.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/mfd/wm8994-core.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
> index 781115e..e8ecb8e 100644
> --- a/drivers/mfd/wm8994-core.c
> +++ b/drivers/mfd/wm8994-core.c
> @@ -245,20 +245,6 @@ static int wm8994_suspend(struct device *dev)
>  		break;
>  	}
>  
> -	switch (wm8994->type) {
> -	case WM1811:
> -		ret = wm8994_reg_read(wm8994, WM8994_ANTIPOP_2);
> -		if (ret < 0) {
> -			dev_err(dev, "Failed to read jackdet: %d\n", ret);
> -		} else if (ret & WM1811_JACKDET_MODE_MASK) {
> -			dev_dbg(dev, "CODEC still active, ignoring suspend\n");
> -			return 0;
> -		}
> -		break;
> -	default:
> -		break;
> -	}
> -
>  	/* Disable LDO pulldowns while the device is suspended if we
>  	 * don't know that something will be driving them. */
>  	if (!wm8994->ldo_ena_always_driven)

I don't see the duplicate?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2013-07-17 11:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 11:20 [PATCH 1/2] mfd: wm8994: Remove duplicate check for active JACKDET Mark Brown
2013-07-17 11:20 ` [PATCH 2/2] mfd: wm8994: Remove check for active audio in runtime suspend Mark Brown
2013-07-17 11:58   ` Lee Jones
2013-07-17 11:52 ` Lee Jones [this message]
2013-07-17 12:14   ` [PATCH 1/2] mfd: wm8994: Remove duplicate check for active JACKDET Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717115249.GE3336@laptop \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=broonie@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.