All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Sergey 'Jin' Bostandzhyan <jin@mediatomb.cc>
Cc: linux-media@vger.kernel.org
Subject: Re: Possible problem with stk1160 driver
Date: Wed, 17 Jul 2013 21:17:53 -0300	[thread overview]
Message-ID: <20130718001752.GA2318@localhost> (raw)
In-Reply-To: <20130717213139.GA14370@deadlock.dhs.org>

Hi Sergey,

On Wed, Jul 17, 2013 at 11:31:39PM +0200, Sergey 'Jin' Bostandzhyan wrote:
> On Wed, Jul 17, 2013 at 05:44:29AM -0300, Ezequiel Garcia wrote:
> > On Wed, Jul 17, 2013 at 12:04:18AM +0200, Sergey 'Jin' Bostandzhyan wrote:
> > > 
> > > It generally works fine, I can, for example, open the video device using VLC,
> > > select one of the inputs and get the picture.
> > > 
> > > However, programs like motion or zoneminder fail, I am not quite sure if it
> > > is something that they might be doing or if it is a problem in the driver.
> > > 
> > > Basically, for both of the above, the problem is that VIDIOC_S_INPUT fails
> > > with EBUSY.
> > > 
> > 
> > I've just sent a patch to fix this issue.
> > 
> > Could you try it and let me know if it solves your issue?
> 
> thanks a lot! Just tried it, same fix is needed for vidioc_s_std(), then
> the errors in motion and zoneminder are gone!
> 

Ah... forgot to mention about that. I haven't included the fix for standard
setting, because either the stk1160 chip or the userspace application didn't
seem to behave properly: I got wrongly coloured frames when trying to
change the standard while streaming.

Can't your problem get fixed by setting an initial standard (e.g. at
/etc/motion configuration file)?

> Motion seems to work now, with zoneminder I get a lot of these messages:
> Jul 17 23:28:27 localhost kernel: [20641.931990] stk1160_copy_video: 5563 callbacks suppressed
> Jul 17 23:28:27 localhost kernel: [20641.931998] stk1160: buffer overflow detected
> Jul 17 23:28:27 localhost kernel: [20641.932000] stk1160: buffer overflow detected
> 
> Anything to worry about?
> 

Not sure. If you're changing the standard while streaming then maybe some component
is not doing things right.

I can take a look at the std thing later, but for now the input
fix looks definitely correct.

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  reply	other threads:[~2013-07-18  0:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 22:04 Possible problem with stk1160 driver Sergey 'Jin' Bostandzhyan
2013-07-16 22:45 ` Ezequiel Garcia
2013-07-17  8:44 ` Ezequiel Garcia
2013-07-17 21:31   ` Sergey 'Jin' Bostandzhyan
2013-07-18  0:17     ` Ezequiel Garcia [this message]
2013-07-18  0:44       ` Sergey 'Jin' Bostandzhyan
2013-07-18  6:31       ` Hans Verkuil
2013-07-18 12:55         ` Ezequiel Garcia
2013-07-18 22:19           ` Sergey 'Jin' Bostandzhyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130718001752.GA2318@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=jin@mediatomb.cc \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.