From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Thu, 18 Jul 2013 07:02:20 +0000 Subject: Re: [PATCH 04/15] ARM: OMAP: USB: Add phy binding information Message-Id: <20130718070219.GM7656@atomide.com> List-Id: References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-5-git-send-email-kishon@ti.com> In-Reply-To: <1374129984-765-5-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org * Kishon Vijay Abraham I [130717 23:53]: > In order for controllers to get PHY in case of non dt boot, the phy > binding information (phy device name) should be added in the platform > data of the controller. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwester Nawrocki > Acked-by: Felipe Balbi > --- > arch/arm/mach-omap2/usb-musb.c | 3 +++ > include/linux/usb/musb.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 8c4de27..6aa7cbf 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -85,6 +85,9 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > + if (cpu_is_omap34xx()) > + musb_plat.phy_label = "twl4030"; > + > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > name = "musb-am35x"; I don't think there's a USB PHY on non-twl4030 chips, so this should be OK: Acked-by: Tony Lindgren > diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h > index 053c268..596f8c8 100644 > --- a/include/linux/usb/musb.h > +++ b/include/linux/usb/musb.h > @@ -104,6 +104,9 @@ struct musb_hdrc_platform_data { > /* for clk_get() */ > const char *clock; > > + /* phy label */ > + const char *phy_label; > + > /* (HOST or OTG) switch VBUS on/off */ > int (*set_vbus)(struct device *dev, int is_on); > > -- > 1.7.10.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 04/15] ARM: OMAP: USB: Add phy binding information Date: Thu, 18 Jul 2013 00:02:20 -0700 Message-ID: <20130718070219.GM7656@atomide.com> References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-5-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1374129984-765-5-git-send-email-kishon-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, balajitk-l0cyMroinI0@public.gmane.org, george.cherian-l0cyMroinI0@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org * Kishon Vijay Abraham I [130717 23:53]: > In order for controllers to get PHY in case of non dt boot, the phy > binding information (phy device name) should be added in the platform > data of the controller. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwester Nawrocki > Acked-by: Felipe Balbi > --- > arch/arm/mach-omap2/usb-musb.c | 3 +++ > include/linux/usb/musb.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 8c4de27..6aa7cbf 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -85,6 +85,9 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > + if (cpu_is_omap34xx()) > + musb_plat.phy_label = "twl4030"; > + > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > name = "musb-am35x"; I don't think there's a USB PHY on non-twl4030 chips, so this should be OK: Acked-by: Tony Lindgren > diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h > index 053c268..596f8c8 100644 > --- a/include/linux/usb/musb.h > +++ b/include/linux/usb/musb.h > @@ -104,6 +104,9 @@ struct musb_hdrc_platform_data { > /* for clk_get() */ > const char *clock; > > + /* phy label */ > + const char *phy_label; > + > /* (HOST or OTG) switch VBUS on/off */ > int (*set_vbus)(struct device *dev, int is_on); > > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 18 Jul 2013 00:02:20 -0700 Subject: [PATCH 04/15] ARM: OMAP: USB: Add phy binding information In-Reply-To: <1374129984-765-5-git-send-email-kishon@ti.com> References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-5-git-send-email-kishon@ti.com> Message-ID: <20130718070219.GM7656@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Kishon Vijay Abraham I [130717 23:53]: > In order for controllers to get PHY in case of non dt boot, the phy > binding information (phy device name) should be added in the platform > data of the controller. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwester Nawrocki > Acked-by: Felipe Balbi > --- > arch/arm/mach-omap2/usb-musb.c | 3 +++ > include/linux/usb/musb.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 8c4de27..6aa7cbf 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -85,6 +85,9 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > + if (cpu_is_omap34xx()) > + musb_plat.phy_label = "twl4030"; > + > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > name = "musb-am35x"; I don't think there's a USB PHY on non-twl4030 chips, so this should be OK: Acked-by: Tony Lindgren > diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h > index 053c268..596f8c8 100644 > --- a/include/linux/usb/musb.h > +++ b/include/linux/usb/musb.h > @@ -104,6 +104,9 @@ struct musb_hdrc_platform_data { > /* for clk_get() */ > const char *clock; > > + /* phy label */ > + const char *phy_label; > + > /* (HOST or OTG) switch VBUS on/off */ > int (*set_vbus)(struct device *dev, int is_on); > > -- > 1.7.10.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:33580 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758335Ab3GRHCd (ORCPT ); Thu, 18 Jul 2013 03:02:33 -0400 Date: Thu, 18 Jul 2013 00:02:20 -0700 From: Tony Lindgren To: Kishon Vijay Abraham I Cc: gregkh@linuxfoundation.org, kyungmin.park@samsung.com, balbi@ti.com, jg1.han@samsung.com, s.nawrocki@samsung.com, kgene.kim@samsung.com, grant.likely@linaro.org, arnd@arndb.de, swarren@nvidia.com, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, akpm@linux-foundation.org, balajitk@ti.com, george.cherian@ti.com, nsekhar@ti.com Subject: Re: [PATCH 04/15] ARM: OMAP: USB: Add phy binding information Message-ID: <20130718070219.GM7656@atomide.com> References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-5-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374129984-765-5-git-send-email-kishon@ti.com> Sender: linux-media-owner@vger.kernel.org List-ID: * Kishon Vijay Abraham I [130717 23:53]: > In order for controllers to get PHY in case of non dt boot, the phy > binding information (phy device name) should be added in the platform > data of the controller. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwester Nawrocki > Acked-by: Felipe Balbi > --- > arch/arm/mach-omap2/usb-musb.c | 3 +++ > include/linux/usb/musb.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index 8c4de27..6aa7cbf 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -85,6 +85,9 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data) > musb_plat.mode = board_data->mode; > musb_plat.extvbus = board_data->extvbus; > > + if (cpu_is_omap34xx()) > + musb_plat.phy_label = "twl4030"; > + > if (soc_is_am35xx()) { > oh_name = "am35x_otg_hs"; > name = "musb-am35x"; I don't think there's a USB PHY on non-twl4030 chips, so this should be OK: Acked-by: Tony Lindgren > diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h > index 053c268..596f8c8 100644 > --- a/include/linux/usb/musb.h > +++ b/include/linux/usb/musb.h > @@ -104,6 +104,9 @@ struct musb_hdrc_platform_data { > /* for clk_get() */ > const char *clock; > > + /* phy label */ > + const char *phy_label; > + > /* (HOST or OTG) switch VBUS on/off */ > int (*set_vbus)(struct device *dev, int is_on); > > -- > 1.7.10.4 >