From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: About omap2 mmc host close too long irq in irqaction. Date: Thu, 18 Jul 2013 10:53:01 +0800 Message-ID: <201307181052572266628@gmail.com> Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: balajitk Cc: cjb , linux-mmc , linux-omap , linux-kernel , devicetree-discuss List-Id: linux-mmc@vger.kernel.org SGkgYWxsLA0KCU5vdyBpIHdvcmtlZCBvbiBvbXAyIGFuZCBtZXQgYSBwcm9iZWxtIHdoaWNoIHNv bWVwbGFjZSBjbG9zZV9pcnEgZm9yIDMuNnNlY29uZC4gDQpUaGUga2VybmVsIHZlcnNpb24gaXMg Mi42LjM3LiBJIHVzZWQgdHJhY2UgdG8gZmluZCBpbiBpcnFfYWN0aW9uOm9tYXBfaHNtbWNfaXJx Lg0KVGhpcyBwcm9ibGVtIG9jY3VyZWQgYnkgcmVtb3ZlZCB0aGUgc2RjYXJkIHdoZW4gdGhlcmUg YXJlIGlvIG9wZXJhdGlvbnMuDQoNCkkgZm91bmQgdGhlIHJlYWQgcHJvYmxlbSBpcyBpbiBvbWFw X2hzbW1jX3Jlc2V0X2NvbnRyb2xsZXJfZnNtLg0KSW4gb21hcF9oc21tY19yZXNldF9jb250cm9s bGVyX2ZzbToNCj5zdGF0aWMgaW5saW5lIHZvaWQgb21hcF9oc21tY19yZXNldF9jb250cm9sbGVy X2ZzbShzdHJ1Y3Qgb21hcF9oc21tY19ob3N0ICpob3N0LA0KPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgYml0KQ0KPnsNCj4g ICAgICAgIHVuc2lnbmVkIGxvbmcgaSA9IDA7IA0KPiAgICAgICAgdW5zaWduZWQgbG9uZyBsaW1p dCA9IChsb29wc19wZXJfamlmZnkgKg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bXNlY3NfdG9famlmZmllcyhNTUNfVElNRU9VVF9NUykpOw0KDQo+ICAgICAgICBPTUFQX0hTTU1D X1dSSVRFKGhvc3QtPmJhc2UsIFNZU0NUTCwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgT01B UF9IU01NQ19SRUFEKGhvc3QtPmJhc2UsIFNZU0NUTCkgfCBiaXQpOw0KDQo+ICAgICAgICAvKiAg IA0KPiAgICAgICAgICogT01BUDQgRVMyIGFuZCBncmVhdGVyIGhhcyBhbiB1cGRhdGVkIHJlc2V0 IGxvZ2ljLg0KPiAgICAgICAgICogTW9uaXRvciBhIDAtPjEgdHJhbnNpdGlvbiBmaXJzdA0KPiAg ICAgICAgICovDQo+ICAgICAgICBpZiAobW1jX3Nsb3QoaG9zdCkuZmVhdHVyZXMgJiBIU01NQ19I QVNfVVBEQVRFRF9SRVNFVCkgew0KPiAgICAgICAgICAgICAgICB3aGlsZSAoKCEoT01BUF9IU01N Q19SRUFEKGhvc3QtPmJhc2UsIFNZU0NUTCkgJiBiaXQpKQ0KPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICYmIChpKysgPCBsaW1pdCkpDQo+ICAgICAgICAgICAgICAgICAg ICAgICAgY3B1X3JlbGF4KCk7DQogICAgICAgIH0gICAgDQogSW4gZnVuYywgaXQgdXNlZCBsb29w c19wZXJfamlmZnkgIGluIG9yZGVyIHRvIGF2b2lkIGRvIG1hbnkgdGltZSBleGNlZWQgTU1DX1RJ TUVPVVRfTVMuDQpJbiBmYWNlIG9vcHNfcGVyX2ppaWZ5IGlzIGxpa2U6DQp3aGlsZShpKysgPCBs b29wc19wZXJfamlmZnkpDQoJY3B1X3JlbGF4KCk7DQpCdXQgYWN0dWFsbHksIGl0IHVzZWQgYXMg Zm9sbG93Og0KPndoaWxlICgoIShPTUFQX0hTTU1DX1JFQUQoaG9zdC0+YmFzZSwgU1lTQ1RMKSAm IGJpdCkpDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmJiAoaSsrIDwg bGltaXQpKQ0KaXQgYWRkIHNvbWUgb3BlcmF0aW9ucyBsaWtlOiByZWFkIHJlZ2lzZ2VyLCAmLCAm Ji4NClNvIHRoZSB0aW1lIG1heSBleGNlZWQgTU1DX1RJTUVPVVRfTVMuDQpJIHVzZWQgdGhvc2Ug Y29kZSB0byB0ZXN0IGFuZCBmb3VuZCBpdCdzIG9rOg0KZm9yIChpID0gMCA7IGkgPCAxMDsgaSsr KXsNCglpZiAoIShPTUFQX0hTTU1DX1JFQUQoaG9zdC0+YmFzZSwgU1lTQ1RMKSAmIGJpdCkpDQoJ CSAgYnJlYWs7DQoJaiA9IGxpbWl0LzEwOw0KCXdoaWxlKGotLSkNCgkJY3B1X3JlbGF4KCk7DQp9 DQoNClVzaW5nIHRoaXMgdGhlIHByb2Jsb20gY2FuJ3Qgb2NjdXIuDQpBbSBpIG1pc3Npbmcgc29t ZXRoaW5nPw0KDQpUaGFua3MhDQpKaWFucGVuZyBNYQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758121Ab3GRCxQ (ORCPT ); Wed, 17 Jul 2013 22:53:16 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:33196 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464Ab3GRCxM (ORCPT ); Wed, 17 Jul 2013 22:53:12 -0400 Date: Thu, 18 Jul 2013 10:53:01 +0800 From: majianpeng To: balajitk Cc: cjb , linux-mmc , linux-omap , linux-kernel , devicetree-discuss Reply-To: majianpeng Subject: About omap2 mmc host close too long irq in irqaction. X-Priority: 3 X-GUID: 5810326C-7B21-457E-8D85-26105C6C44B9 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.90[en] Mime-Version: 1.0 Message-ID: <201307181052572266628@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r6I2rg5n032753 Hi all, Now i worked on omp2 and met a probelm which someplace close_irq for 3.6second. The kernel version is 2.6.37. I used trace to find in irq_action:omap_hsmmc_irq. This problem occured by removed the sdcard when there are io operations. I found the read problem is in omap_hsmmc_reset_controller_fsm. In omap_hsmmc_reset_controller_fsm: >static inline void omap_hsmmc_reset_controller_fsm(struct omap_hsmmc_host *host, > unsigned long bit) >{ > unsigned long i = 0; > unsigned long limit = (loops_per_jiffy * > msecs_to_jiffies(MMC_TIMEOUT_MS)); > OMAP_HSMMC_WRITE(host->base, SYSCTL, > OMAP_HSMMC_READ(host->base, SYSCTL) | bit); > /* > * OMAP4 ES2 and greater has an updated reset logic. > * Monitor a 0->1 transition first > */ > if (mmc_slot(host).features & HSMMC_HAS_UPDATED_RESET) { > while ((!(OMAP_HSMMC_READ(host->base, SYSCTL) & bit)) > && (i++ < limit)) > cpu_relax(); } In func, it used loops_per_jiffy in order to avoid do many time exceed MMC_TIMEOUT_MS. In face oops_per_jiify is like: while(i++ < loops_per_jiffy) cpu_relax(); But actually, it used as follow: >while ((!(OMAP_HSMMC_READ(host->base, SYSCTL) & bit)) > && (i++ < limit)) it add some operations like: read regisger, &, &&. So the time may exceed MMC_TIMEOUT_MS. I used those code to test and found it's ok: for (i = 0 ; i < 10; i++){ if (!(OMAP_HSMMC_READ(host->base, SYSCTL) & bit)) break; j = limit/10; while(j--) cpu_relax(); } Using this the problom can't occur. Am i missing something? Thanks! Jianpeng Ma{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I