From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Thu, 18 Jul 2013 10:55:06 -0300 Subject: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation In-Reply-To: <51E63B3A.2010807@keymile.com> References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51E5145A.90404@keymile.com> <20130716125531.GD2317@localhost> <51E63B3A.2010807@keymile.com> Message-ID: <20130718135505.GA3264@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Gerlando, On Wed, Jul 17, 2013 at 08:35:38AM +0200, Gerlando Falauto wrote: > On 07/16/2013 02:56 PM, Ezequiel Garcia wrote: > [...] > > Also, speaking of "device bus" this nand node should be behind a devicebus node. > > > > ranges = > MBUS_ID(0x01, 0x2f) 0 0 0xf4000000 0x400>; > > > > devbus { > > status = "okay"; > > ranges = <0 MBUS_ID(0x01, 0x2f) 0 0x400>; > > > > /* nand */ > > nand { > > compatible = "marvell,orion-nand"; > > reg = <0 0x400>; > > }; > > }; > > > > (notice this will allow you to relocate the base address of the NAND windows > > easily if it conflicts with your PCIe needs). > > I am MAYBE slowly starting to understand this whole mbus rework. > Just one remark though: don't you think it would make sense to add > something like: > > #define MBUS_ID_INTERNAL_REGS MBUS_ID(0xf0, 0x01) > #define MBUS_ID_NAND MBUS_ID(0x01, 0x2f) > Yeah, maybe it would make sense. This has been discussed in the past and others were against, so that's the reason it's not included in the series I submitted. But feel free to send a patch proposing it once the MBus is merged! Thanks, -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation Date: Thu, 18 Jul 2013 10:55:06 -0300 Message-ID: <20130718135505.GA3264@localhost> References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51E5145A.90404@keymile.com> <20130716125531.GD2317@localhost> <51E63B3A.2010807@keymile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <51E63B3A.2010807-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Gerlando Falauto Cc: Lior Amsalem , Andrew Lunn , Jason Cooper , "Longchamp, Valentin" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Jason Gunthorpe , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgR2VybGFuZG8sCgpPbiBXZWQsIEp1bCAxNywgMjAxMyBhdCAwODozNTozOEFNICswMjAwLCBH ZXJsYW5kbyBGYWxhdXRvIHdyb3RlOgo+IE9uIDA3LzE2LzIwMTMgMDI6NTYgUE0sIEV6ZXF1aWVs IEdhcmNpYSB3cm90ZToKPiBbLi4uXQo+ID4gQWxzbywgc3BlYWtpbmcgb2YgImRldmljZSBidXMi IHRoaXMgbmFuZCBub2RlIHNob3VsZCBiZSBiZWhpbmQgYSBkZXZpY2VidXMgbm9kZS4KPiA+Cj4g PiAJCXJhbmdlcyA9IDxNQlVTX0lEKDB4ZjAsIDB4MDEpIDAgMCAweGYxMDAwMDAwIDB4MTAwMDAw ICAgLyogaW50ZXJuYWwtcmVncyAqLwo+ID4gCQkJICBNQlVTX0lEKDB4MDEsIDB4MmYpIDAgMCAw eGY0MDAwMDAwIDB4NDAwPjsKPiA+Cj4gPiAJCWRldmJ1cyB7Cj4gPiAJCQlzdGF0dXMgPSAib2th eSI7Cj4gPiAJCQlyYW5nZXMgPSA8MCBNQlVTX0lEKDB4MDEsIDB4MmYpIDAgMHg0MDA+Owo+ID4K PiA+IAkJCS8qIG5hbmQgKi8KPiA+IAkJCW5hbmQgewo+ID4gCQkJCWNvbXBhdGlibGUgPSAibWFy dmVsbCxvcmlvbi1uYW5kIjsKPiA+IAkJCQlyZWcgPSA8MCAweDQwMD47Cj4gPiAJCQl9Owo+ID4g CQl9Owo+ID4KPiA+IChub3RpY2UgdGhpcyB3aWxsIGFsbG93IHlvdSB0byByZWxvY2F0ZSB0aGUg YmFzZSBhZGRyZXNzIG9mIHRoZSBOQU5EIHdpbmRvd3MKPiA+IGVhc2lseSBpZiBpdCBjb25mbGlj dHMgd2l0aCB5b3VyIFBDSWUgbmVlZHMpLgo+IAo+IEkgYW0gTUFZQkUgc2xvd2x5IHN0YXJ0aW5n IHRvIHVuZGVyc3RhbmQgdGhpcyB3aG9sZSBtYnVzIHJld29yay4KPiBKdXN0IG9uZSByZW1hcmsg dGhvdWdoOiBkb24ndCB5b3UgdGhpbmsgaXQgd291bGQgbWFrZSBzZW5zZSB0byBhZGQgCj4gc29t ZXRoaW5nIGxpa2U6Cj4gCj4gI2RlZmluZSBNQlVTX0lEX0lOVEVSTkFMX1JFR1MJTUJVU19JRCgw eGYwLCAweDAxKQo+ICNkZWZpbmUgTUJVU19JRF9OQU5ECQlNQlVTX0lEKDB4MDEsIDB4MmYpCj4g CgpZZWFoLCBtYXliZSBpdCB3b3VsZCBtYWtlIHNlbnNlLiBUaGlzIGhhcyBiZWVuIGRpc2N1c3Nl ZCBpbiB0aGUgcGFzdAphbmQgb3RoZXJzIHdlcmUgYWdhaW5zdCwgc28gdGhhdCdzIHRoZSByZWFz b24gaXQncyBub3QgaW5jbHVkZWQgaW4KdGhlIHNlcmllcyBJIHN1Ym1pdHRlZC4KCkJ1dCBmZWVs IGZyZWUgdG8gc2VuZCBhIHBhdGNoIHByb3Bvc2luZyBpdCBvbmNlIHRoZSBNQnVzIGlzIG1lcmdl ZCEKClRoYW5rcywKLS0gCkV6ZXF1aWVsIEdhcmPDrWEsIEZyZWUgRWxlY3Ryb25zCkVtYmVkZGVk IExpbnV4LCBLZXJuZWwgYW5kIEFuZHJvaWQgRW5naW5lZXJpbmcKaHR0cDovL2ZyZWUtZWxlY3Ry b25zLmNvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk ZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5v emxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0cmVlLWRp c2N1c3MK