From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Thu, 18 Jul 2013 11:05:51 -0300 Subject: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation In-Reply-To: <51E59639.3000207@keymile.com> References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51E5145A.90404@keymile.com> <20130716125531.GD2317@localhost> <51E59639.3000207@keymile.com> Message-ID: <20130718140550.GA3364@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Gerlando, On Tue, Jul 16, 2013 at 08:51:37PM +0200, Gerlando Falauto wrote: [...] > > > > Also, speaking of "device bus" this nand node should be behind a devicebus node. > > > > ranges = > MBUS_ID(0x01, 0x2f) 0 0 0xf4000000 0x400>; > > > > devbus { > > status = "okay"; > > ranges = <0 MBUS_ID(0x01, 0x2f) 0 0x400>; > > > > /* nand */ > > nand { > > compatible = "marvell,orion-nand"; > > reg = <0 0x400>; > > }; > > }; > > I believe that makes a lot more sense this way... I guess this feature > (device bus) requires your latest set of patches, right? (either v7 as > you posted yesterday or your tree at > git://github.com/MISL-EBU-System-SW/mainline-public.git/marvell-mvebu-mbus-v7) > No, not really. The device-bus driver is already merged, so we only need to use it, and maybe extend it a bit to support kirkwood (in case it's needed). You can see in: arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts for an example. I would prefer that to be done *after* the MBus is accepted... but that's just a personal preference. > > (notice this will allow you to relocate the base address of the NAND windows > > easily if it conflicts with your PCIe needs). > > I sort of had the impression I could do already do that somehow, though > I am not quite sure anymore... > Well, you can do it by patching and re-building the kernel as the MBus windows are created from C-files. With the MBus DT binding, all you need is to change the DT. > >> avoid a later incosistency between the "unit-address" and the first > >> "reg" address: > >> > >>> #address-cells = <1>; > >>> #size-cells = <1>; > >>> @@ -171,7 +172,7 @@ > >> > nand at 3000000 { > >> ^^^^^^^ > > > > Oh, this should be fixed. I just missed it, and nobody noticed either. > > > > So, in the end, you think it's OK to have a set of nodes with "relative" > addresses (gpio at 10140, serial at 12000 etc...) and some with "absolute" > addresses (nand at 0xf4000000, where the ranges property does a 0-offset > translation)? > Even though I understand this is just some transitional state, and it > will all be fixed like your example above, once we get the rest of the > rework merged (mbus/devbus). Mmm.. I see your point. In the end, it's just as you say, the current state is only transitional. There's no way to have a proper DT without the MBus DT binding. The reason for this mess is that the current layout mixes the actual address space. Feel free to take a look at the latest MBus series and try to add MBus DT binding for Kirkwood. If you do, don't hesitate in asking as many questions as you need and/or posting RFCs for us to look at. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation Date: Thu, 18 Jul 2013 11:05:51 -0300 Message-ID: <20130718140550.GA3364@localhost> References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51E5145A.90404@keymile.com> <20130716125531.GD2317@localhost> <51E59639.3000207@keymile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <51E59639.3000207-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Gerlando Falauto Cc: Lior Amsalem , Andrew Lunn , Jason Cooper , "Longchamp, Valentin" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Jason Gunthorpe , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org R2VybGFuZG8sCgpPbiBUdWUsIEp1bCAxNiwgMjAxMyBhdCAwODo1MTozN1BNICswMjAwLCBHZXJs YW5kbyBGYWxhdXRvIHdyb3RlOgpbLi4uXQo+ID4KPiA+IEFsc28sIHNwZWFraW5nIG9mICJkZXZp Y2UgYnVzIiB0aGlzIG5hbmQgbm9kZSBzaG91bGQgYmUgYmVoaW5kIGEgZGV2aWNlYnVzIG5vZGUu Cj4gPgo+ID4gCQlyYW5nZXMgPSA8TUJVU19JRCgweGYwLCAweDAxKSAwIDAgMHhmMTAwMDAwMCAw eDEwMDAwMCAgIC8qIGludGVybmFsLXJlZ3MgKi8KPiA+IAkJCSAgTUJVU19JRCgweDAxLCAweDJm KSAwIDAgMHhmNDAwMDAwMCAweDQwMD47Cj4gPgo+ID4gCQlkZXZidXMgewo+ID4gCQkJc3RhdHVz ID0gIm9rYXkiOwo+ID4gCQkJcmFuZ2VzID0gPDAgTUJVU19JRCgweDAxLCAweDJmKSAwIDB4NDAw PjsKPiA+Cj4gPiAJCQkvKiBuYW5kICovCj4gPiAJCQluYW5kIHsKPiA+IAkJCQljb21wYXRpYmxl ID0gIm1hcnZlbGwsb3Jpb24tbmFuZCI7Cj4gPiAJCQkJcmVnID0gPDAgMHg0MDA+Owo+ID4gCQkJ fTsKPiA+IAkJfTsKPiAKPiBJIGJlbGlldmUgdGhhdCBtYWtlcyBhIGxvdCBtb3JlIHNlbnNlIHRo aXMgd2F5Li4uIEkgZ3Vlc3MgdGhpcyBmZWF0dXJlIAo+IChkZXZpY2UgYnVzKSByZXF1aXJlcyB5 b3VyIGxhdGVzdCBzZXQgb2YgcGF0Y2hlcywgcmlnaHQ/IChlaXRoZXIgdjcgYXMgCj4geW91IHBv c3RlZCB5ZXN0ZXJkYXkgb3IgeW91ciB0cmVlIGF0IAo+IGdpdDovL2dpdGh1Yi5jb20vTUlTTC1F QlUtU3lzdGVtLVNXL21haW5saW5lLXB1YmxpYy5naXQvbWFydmVsbC1tdmVidS1tYnVzLXY3KQo+ IAoKTm8sIG5vdCByZWFsbHkuIFRoZSBkZXZpY2UtYnVzIGRyaXZlciBpcyBhbHJlYWR5IG1lcmdl ZCwgc28gd2Ugb25seSBuZWVkCnRvIHVzZSBpdCwgYW5kIG1heWJlIGV4dGVuZCBpdCBhIGJpdCB0 byBzdXBwb3J0IGtpcmt3b29kIChpbiBjYXNlIGl0J3MKbmVlZGVkKS4gWW91IGNhbiBzZWUgaW46 CgogIGFyY2gvYXJtL2Jvb3QvZHRzL2FybWFkYS14cC1vcGVuYmxvY2tzLWF4My00LmR0cwoKZm9y IGFuIGV4YW1wbGUuCgpJIHdvdWxkIHByZWZlciB0aGF0IHRvIGJlIGRvbmUgKmFmdGVyKiB0aGUg TUJ1cyBpcyBhY2NlcHRlZC4uLgpidXQgdGhhdCdzIGp1c3QgYSBwZXJzb25hbCBwcmVmZXJlbmNl LgoKPiA+IChub3RpY2UgdGhpcyB3aWxsIGFsbG93IHlvdSB0byByZWxvY2F0ZSB0aGUgYmFzZSBh ZGRyZXNzIG9mIHRoZSBOQU5EIHdpbmRvd3MKPiA+IGVhc2lseSBpZiBpdCBjb25mbGljdHMgd2l0 aCB5b3VyIFBDSWUgbmVlZHMpLgo+IAo+IEkgc29ydCBvZiBoYWQgdGhlIGltcHJlc3Npb24gSSBj b3VsZCBkbyBhbHJlYWR5IGRvIHRoYXQgc29tZWhvdywgdGhvdWdoIAo+IEkgYW0gbm90IHF1aXRl IHN1cmUgYW55bW9yZS4uLgo+IAoKV2VsbCwgeW91IGNhbiBkbyBpdCBieSBwYXRjaGluZyBhbmQg cmUtYnVpbGRpbmcgdGhlIGtlcm5lbCBhcyB0aGUKTUJ1cyB3aW5kb3dzIGFyZSBjcmVhdGVkIGZy b20gQy1maWxlcy4KCldpdGggdGhlIE1CdXMgRFQgYmluZGluZywgYWxsIHlvdSBuZWVkIGlzIHRv IGNoYW5nZSB0aGUgRFQuCgo+ID4+IGF2b2lkIGEgbGF0ZXIgaW5jb3Npc3RlbmN5IGJldHdlZW4g dGhlICJ1bml0LWFkZHJlc3MiIGFuZCB0aGUgZmlyc3QKPiA+PiAicmVnIiBhZGRyZXNzOgo+ID4+ Cj4gPj4+ICAgIAkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPj4+ICAgIAkJI3NpemUtY2VsbHMg PSA8MT47Cj4gPj4+IEBAIC0xNzEsNyArMTcyLDcgQEAKPiA+PiAgID4gICAJCW5hbmRAMzAwMDAw MCB7Cj4gPj4gCQkgICAgIF5eXl5eXl4KPiA+Cj4gPiBPaCwgdGhpcyBzaG91bGQgYmUgZml4ZWQu IEkganVzdCBtaXNzZWQgaXQsIGFuZCBub2JvZHkgbm90aWNlZCBlaXRoZXIuCj4gPgo+IAo+IFNv LCBpbiB0aGUgZW5kLCB5b3UgdGhpbmsgaXQncyBPSyB0byBoYXZlIGEgc2V0IG9mIG5vZGVzIHdp dGggInJlbGF0aXZlIiAKPiBhZGRyZXNzZXMgKGdwaW9AMTAxNDAsIHNlcmlhbEAxMjAwMCBldGMu Li4pIGFuZCBzb21lIHdpdGggImFic29sdXRlIiAKPiBhZGRyZXNzZXMgKG5hbmRAMHhmNDAwMDAw MCwgd2hlcmUgdGhlIHJhbmdlcyBwcm9wZXJ0eSBkb2VzIGEgMC1vZmZzZXQgCj4gdHJhbnNsYXRp b24pPwo+IEV2ZW4gdGhvdWdoIEkgdW5kZXJzdGFuZCB0aGlzIGlzIGp1c3Qgc29tZSB0cmFuc2l0 aW9uYWwgc3RhdGUsIGFuZCBpdCAKPiB3aWxsIGFsbCBiZSBmaXhlZCBsaWtlIHlvdXIgZXhhbXBs ZSBhYm92ZSwgb25jZSB3ZSBnZXQgdGhlIHJlc3Qgb2YgdGhlIAo+IHJld29yayBtZXJnZWQgKG1i dXMvZGV2YnVzKS4KCk1tbS4uIEkgc2VlIHlvdXIgcG9pbnQuIEluIHRoZSBlbmQsIGl0J3MganVz dCBhcyB5b3Ugc2F5LCB0aGUgY3VycmVudCBzdGF0ZQppcyBvbmx5IHRyYW5zaXRpb25hbC4gVGhl cmUncyBubyB3YXkgdG8gaGF2ZSBhIHByb3BlciBEVCB3aXRob3V0IHRoZSBNQnVzIERUCmJpbmRp bmcuCgpUaGUgcmVhc29uIGZvciB0aGlzIG1lc3MgaXMgdGhhdCB0aGUgY3VycmVudCBsYXlvdXQg bWl4ZXMgdGhlIGFjdHVhbAphZGRyZXNzIHNwYWNlLiBGZWVsIGZyZWUgdG8gdGFrZSBhIGxvb2sg YXQgdGhlIGxhdGVzdCBNQnVzIHNlcmllcyBhbmQKdHJ5IHRvIGFkZCBNQnVzIERUIGJpbmRpbmcg Zm9yIEtpcmt3b29kLgoKSWYgeW91IGRvLCBkb24ndCBoZXNpdGF0ZSBpbiBhc2tpbmcgYXMgbWFu eSBxdWVzdGlvbnMgYXMgeW91IG5lZWQgYW5kL29yCnBvc3RpbmcgUkZDcyBmb3IgdXMgdG8gbG9v ayBhdC4KCi0tIApFemVxdWllbCBHYXJjw61hLCBGcmVlIEVsZWN0cm9ucwpFbWJlZGRlZCBMaW51 eCwgS2VybmVsIGFuZCBBbmRyb2lkIEVuZ2luZWVyaW5nCmh0dHA6Ly9mcmVlLWVsZWN0cm9ucy5j b20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNl dHJlZS1kaXNjdXNzIG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJz Lm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNz Cg==