From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] toolchain: instrument external toolchain wrapper
Date: Thu, 18 Jul 2013 23:32:56 +0200 [thread overview]
Message-ID: <20130718233256.39fc8342@skate> (raw)
In-Reply-To: <574ef0eb7e941dcc6c9dba3540f4aa1c213472bc.1374182572.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
I like the feature, but it would be nice if the coding was more
consistent with the rest of the code, see below:
On Thu, 18 Jul 2013 23:24:15 +0200, Yann E. MORIN wrote:
> + if( getenv("BR_DEBUG_WRAPPER") ) {
No space after ( and before ).
> + fprintf( stderr, "path='%s'\n", path );
Dirro.
> + int i;
Variable declaration in the middle of the code. I know it's C99 ok, but
I'd prefer not to have that (just like the kernel).
> + for( i=0; args[i]; i++ ) {
for (i = 0; args[i]; i++)
> + fprintf(stderr, "argv[%d]='%s'\n", i, args[i] );
Ditto space before ).
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-07-18 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 21:24 [Buildroot] [pull request] Pull request for branch yem-misc-updates Yann E. MORIN
2013-07-18 21:24 ` [Buildroot] [PATCH 1/4] defconfig/rpi: bump kernel for misc fixes Yann E. MORIN
2013-07-18 22:33 ` Peter Korsgaard
2013-07-18 21:24 ` [Buildroot] [PATCH 2/4] package/nss-mdns: fix avahi socket location Yann E. MORIN
2013-07-18 22:34 ` Peter Korsgaard
2013-07-18 21:24 ` [Buildroot] [PATCH 3/4] package/nss-mdns: do not overwrite user's nsswitch.conf Yann E. MORIN
2013-07-18 22:39 ` Peter Korsgaard
2013-07-18 21:24 ` [Buildroot] [PATCH 4/4] toolchain: instrument external toolchain wrapper Yann E. MORIN
2013-07-18 21:32 ` Thomas Petazzoni [this message]
2013-07-18 21:39 ` Yann E. MORIN
2013-07-18 21:54 ` [Buildroot] [PATCHv2 " Yann E. MORIN
2013-07-19 6:33 ` Peter Korsgaard
2013-07-19 16:13 ` Yann E. MORIN
2013-07-19 21:30 ` Peter Korsgaard
2013-07-19 21:39 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718233256.39fc8342@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.