All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, b42378@freescale.com,
	shawn.guo@linaro.org
Subject: Re: [PATCH] ASoC: wm8962: No need to call wm8962_configure_bclk() multiple times
Date: Fri, 19 Jul 2013 11:07:04 +0100	[thread overview]
Message-ID: <20130719100704.GD9858@sirena.org.uk> (raw)
In-Reply-To: <1374213508-25617-1-git-send-email-festevam@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]

On Fri, Jul 19, 2013 at 02:58:28AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Currently after playing any audio file, we get the following error message:
> 
> $ aplay clarinet.wav 
> Playing WAVE 'clarinet.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo
> $ wm8962 0-001a: Unsupported sysclk ratio 544
> 
> This error message appears about 5 seconds after the audio playback has 
> finished.
> 
> There is no need to re-calculate the bit clock after the playback has finished,
> so call wm8962_configure_bclk only once inside wm8962_hw_params(). 

No, you do end up needing to call it in multiple places - there's other
configuration going on there that is needed by bypass paths which won't
use the audio interface and hence won't call hw_params().

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      parent reply	other threads:[~2013-07-19 10:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  5:58 [PATCH] ASoC: wm8962: No need to call wm8962_configure_bclk() multiple times Fabio Estevam
2013-07-19  6:00 ` Nicolin Chen
2013-07-19 10:07 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130719100704.GD9858@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=b42378@freescale.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.