All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexandru Juncu <alexj@rosedu.org>
Cc: Pekka Enberg <penberg@kernel.org>,
	"andreas.dilger" <andreas.dilger@intel.com>,
	"tao.peng" <tao.peng@emc.com>,
	driverdev <devel@driverdev.osuosl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lustre:libcfs: remove redundant code.
Date: Fri, 19 Jul 2013 08:46:48 -0700	[thread overview]
Message-ID: <20130719154648.GA23116@kroah.com> (raw)
In-Reply-To: <CAPhGq=Y30i0RWJTcomt5sRdKX6RDzdGHBo5L9D6coH8O0ej6kA@mail.gmail.com>

On Fri, Jul 19, 2013 at 06:29:34PM +0300, Alexandru Juncu wrote:
> On 19 July 2013 18:21, Pekka Enberg <penberg@kernel.org> wrote:
> > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu <alexj@rosedu.org> wrote:
> >> I was thinking the same thing, but I hesitated because I didn't know
> >> how used it was and I didn't want to break something.
> >
> > "git grep cfs_strdup" suggests that nobody uses it so you could just
> > remove it completely...
> 
> Did a grep on the tree and yes, it's not used. But It's in a staging
> directory so maybe the rest of the code has not been pushed in yet.

Doesn't matter, if there are no users, please just remove it.

thanks,

greg k-h

  reply	other threads:[~2013-07-19 15:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 14:45 [PATCH] lustre:libcfs: remove redundant code Alexandru Juncu
2013-07-19 15:08 ` Pekka Enberg
2013-07-19 15:13   ` Alexandru Juncu
2013-07-19 15:21     ` Pekka Enberg
2013-07-19 15:29       ` Alexandru Juncu
2013-07-19 15:46         ` Greg Kroah-Hartman [this message]
2013-07-19 16:07           ` Paul Bolle
2013-07-19 16:22             ` Alexandru Juncu
2013-07-22  2:07             ` Peng, Tao
2013-07-22  9:04               ` Paul Bolle
2013-07-19 16:29           ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130719154648.GA23116@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexj@rosedu.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=tao.peng@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.