From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0IXz-0000kx-Ky for qemu-devel@nongnu.org; Fri, 19 Jul 2013 17:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0IXx-0006wp-9g for qemu-devel@nongnu.org; Fri, 19 Jul 2013 17:49:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0IXx-0006wj-26 for qemu-devel@nongnu.org; Fri, 19 Jul 2013 17:49:05 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6JLn3mt020481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Jul 2013 17:49:03 -0400 Date: Fri, 19 Jul 2013 14:49:00 -0700 From: Ian Main Message-ID: <20130719214900.GE13675@gate.mains.priv> References: <1374253411-17162-1-git-send-email-imain@redhat.com> <1374253411-17162-2-git-send-email-imain@redhat.com> <51E99656.7020209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E99656.7020209@redhat.com> Subject: Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Fri, Jul 19, 2013 at 01:41:10PM -0600, Eric Blake wrote: > On 07/19/2013 11:03 AM, Ian Main wrote: > > This patch adds sync-modes to the drive-backup interface and > > implements the FULL, NONE and TOP modes of synchronization. > > > > > Signed-off-by: Ian Main > > --- > > block/backup.c | 91 +++++++++++++++++++++++++++++++---------------- > > blockdev.c | 25 ++++++++----- > > include/block/block_int.h | 4 ++- > > qapi-schema.json | 4 +++ > > qmp-commands.hx | 1 + > > 5 files changed, 86 insertions(+), 39 deletions(-) > > > > > +++ b/qapi-schema.json > > @@ -1807,6 +1807,10 @@ > > # @format: #optional the format of the new destination, default is to > > # probe if @mode is 'existing', else the format of the source > > # > > +# @sync: what parts of the disk image should be copied to the destination > > +# (all the disk, only the sectors allocated in the topmost image, or > > +# only new I/O). > > +# > > # @mode: #optional whether and how QEMU should create a new image, default is > > # 'absolute-paths'. > > # > > This hunk is still wrong. And we still haven't answered the > meta-question on whether @format should be mandatory (which I'd rather > fix that first, then rebase this on top of that). How is it wrong when it cleanly applies? You want it separated into another patch? Ian