From: "Jörn Engel" <joern@logfs.org>
To: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>,
Sreekanth Reddy <Sreekanth.Reddy@lsi.com>,
support@lsi.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
DL-MPTFusionLinux@lsi.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, mit@purestorage.com
Subject: Re: [PATCH] mpt2sas: don't handle broadcast primitives
Date: Fri, 19 Jul 2013 18:11:43 -0400 [thread overview]
Message-ID: <20130719221143.GG29404@logfs.org> (raw)
In-Reply-To: <20130719220659.GF29404@logfs.org>
On Fri, 19 July 2013 18:06:59 -0400, Jörn Engel wrote:
>
> The handling of broadcast primitives involves
> _scsih_block_io_all_device(), which does what the name implies. I have
> observed cases with >60s of blocking io on all devices, caused by a
> single bad device. The downsides of this code are obvious, while the
> upsides are more elusive.
And since this patch looks more like an April fools joke: I have
gathered a few machine-months of testing, including tortures that
specifically stress the removed codepaths. This is a serious
submission and unless someone can show me a _very_ good reason for
keeping the deleted code, I would like to get it merged.
Jörn
--
Computer system analysis is like child-rearing; you can do grievous damage,
but you cannot ensure success."
-- Tom DeMarco
next prev parent reply other threads:[~2013-07-19 22:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 22:07 [PATCH] mpt2sas: don't handle broadcast primitives Jörn Engel
2013-07-19 22:11 ` Jörn Engel [this message]
2013-07-24 20:42 ` Baruch Even
2013-07-24 20:42 ` Baruch Even
2013-07-24 19:23 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719221143.GG29404@logfs.org \
--to=joern@logfs.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=JBottomley@parallels.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mit@purestorage.com \
--cc=support@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.