From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0NZt-0006zA-I7 for qemu-devel@nongnu.org; Fri, 19 Jul 2013 23:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0NZq-0002cS-Tn for qemu-devel@nongnu.org; Fri, 19 Jul 2013 23:11:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0NZq-0002cO-MQ for qemu-devel@nongnu.org; Fri, 19 Jul 2013 23:11:22 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6K3BLLF016163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Jul 2013 23:11:21 -0400 Date: Fri, 19 Jul 2013 20:11:17 -0700 From: Ian Main Message-ID: <20130720031117.GG13675@gate.mains.priv> References: <1374253411-17162-1-git-send-email-imain@redhat.com> <1374253411-17162-2-git-send-email-imain@redhat.com> <51E99656.7020209@redhat.com> <20130719214900.GE13675@gate.mains.priv> <51E9B981.2000104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E9B981.2000104@redhat.com> Subject: Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Fri, Jul 19, 2013 at 04:11:13PM -0600, Eric Blake wrote: > On 07/19/2013 03:49 PM, Ian Main wrote: > >>> +++ b/qapi-schema.json > >>> @@ -1807,6 +1807,10 @@ > >>> # @format: #optional the format of the new destination, default is to > >>> # probe if @mode is 'existing', else the format of the source > >>> # > >>> +# @sync: what parts of the disk image should be copied to the destination > >>> +# (all the disk, only the sectors allocated in the topmost image, or > >>> +# only new I/O). > >>> +# > >>> # @mode: #optional whether and how QEMU should create a new image, default is > >>> # 'absolute-paths'. > >>> # > >> > >> This hunk is still wrong. And we still haven't answered the > >> meta-question on whether @format should be mandatory (which I'd rather > >> fix that first, then rebase this on top of that). > > > > How is it wrong when it cleanly applies? You want it separated into > > another patch? > > It cleanly applied to the wrong place (drive-mirror), no thanks to git's > automatic fuzzing. It is _no longer necessary_ - DriveBackup already > has this information. I want it dropped completely. I gotcha sorry I'm slow. Ian