From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Sat, 20 Jul 2013 15:54:44 -0300 Subject: [RESEND PATCH v7 00/22] MBus DT binding: The return of PCIe In-Reply-To: <20130720173847.GC26625@lunn.ch> References: <1373900271-4722-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130720165855.GB26625@lunn.ch> <20130720173847.GC26625@lunn.ch> Message-ID: <20130720185443.GB21460@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Andrew, On Sat, Jul 20, 2013 at 07:38:47PM +0200, Andrew Lunn wrote: > On Sat, Jul 20, 2013 at 06:58:55PM +0200, Andrew Lunn wrote: > > On Mon, Jul 15, 2013 at 11:57:29AM -0300, Ezequiel Garcia wrote: > > > Here's the new MBus DT binding, implementing the changes proposed > > > by Thomas when we discussed the previous patchset: > > > > > > http://www.spinics.net/lists/arm-kernel/msg257170.html > > > > > > As far as I know, this round fixes *all* the concerns raised in the past > > > and therefore I'd like to get Acked-by's from all the parties involved > > > on the respective patches, and particularly for the DT binding. > > > > > > If there's anything left to review, we'll be glad to fix it quickly, > > > so don't hesitate in providing your feedback! > > > > > > I'm sure many of you are dying to test this new MBus thing, so to make > > > it easier for those courageous enough, I've pushed a public branch: > > > > > > https://github.com/MISL-EBU-System-SW/mainline-public/tree/marvell-mvebu-mbus-v7 > > > > I just tried this in my Kirkwood QNAP. > > > > Uncompressing Linux... done, booting the kernel. > > Booting Linux on physical CPU 0x0 > > Linux version 3.11.0-rc1-00022-g44e8c39 (lunn at londo.lunn.ch) (gcc version 4.3.43 > > CPU: Feroceon 88FR131 [56251311] revision 1 (ARMv5TE), cr=00053977 > > CPU: VIVT data cache, VIVT instruction cache > > Machine: Marvell Kirkwood (Flattened Device Tree), model: QNAP TS219 family > > bootconsole [earlycon0] enabled > > Memory policy: ECC disabled, Data cache writeback > > Built 1 zonelists in Zone order, mobility grouping on. Total pages: 130048 > > Kernel command line: root=/dev/sda2 console=ttyS0,115200 earlyprintk > > PID hash table entries: 2048 (order: 1, 8192 bytes) > > Dentry cache hash table entries: 65536 (order: 6, 262144 bytes) > > Inode-cache hash table entries: 32768 (order: 5, 131072 bytes) > > Memory: 513268K/524288K available (4247K kernel code, 241K rwdata, 1148K rodata) > > Virtual kernel memory layout: > > vector : 0xffff0000 - 0xffff1000 ( 4 kB) > > fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB) > > vmalloc : 0xe0800000 - 0xff000000 ( 488 MB) > > lowmem : 0xc0000000 - 0xe0000000 ( 512 MB) > > modules : 0xbf000000 - 0xc0000000 ( 16 MB) > > .text : 0xc0008000 - 0xc054d050 (5397 kB) > > .init : 0xc054e000 - 0xc0576520 ( 162 kB) > > .data : 0xc0578000 - 0xc05b4420 ( 242 kB) > > .bss : 0xc05b4420 - 0xc064e104 ( 616 kB) > > SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 > > Preemptible hierarchical RCU implementation. > > NR_IRQS:114 > > sched_clock: 32 bits at 200MHz, resolution 5ns, wraps every 21474ms > > Console: colour dummy device 80x30 > > Calibrating delay loop... 1587.60 BogoMIPS (lpj=7938048) > > pid_max: default: 32768 minimum: 301 > > Mount-cache hash table entries: 512 > > CPU: Testing write buffer coherency: ok > > Setting up static identity map for 0xc040e888 - 0xc040e8c4 > > pinctrl core: initialized pinctrl subsystem > > regulator-dummy: no parameters > > NET: Registered protocol family 16 > > DMA: preallocated 256 KiB pool for atomic coherent allocations > > Kirkwood: MV88F6282-Rev-A0, TCLK=200000000. > > Feroceon L2: Enabling L2 > > Feroceon L2: Cache support initialised. > > bio: create slab at 0 [...] > > mvebu-pcie pcie-controller.1: PCIe0.0: cannot get tgt/attr for mem window > > mvebu-pcie pcie-controller.1: PCIe1.0: cannot get tgt/attr for mem window [...] > > Any ideas? > The patchset works only for Armada 370 and Armada XP SoC, not for Kirkwood. For some reason I was completely sure there wasn't any DT-enabled Kirkwood boards with PCIe support. I apologize for not noticing this before! My plan was to get this patchset acked/merged and then add MBus DT to Kirkwood. The reason for this is that it's a simple change, but probably *very* intrusive on the DTS files. Of course, this plan was based on the assumption that the wasn't breaking anything. However, now I guess there's no other solution than adding Kirkwood to the patchset. So unless anyone has any better idea, I'll be sending a v8. Thanks again for the test! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [RESEND PATCH v7 00/22] MBus DT binding: The return of PCIe Date: Sat, 20 Jul 2013 15:54:44 -0300 Message-ID: <20130720185443.GB21460@localhost> References: <1373900271-4722-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130720165855.GB26625@lunn.ch> <20130720173847.GC26625@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20130720173847.GC26625-g2DYL2Zd6BY@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Andrew Lunn Cc: Lior Amsalem , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jason Gunthorpe , Maen Suleiman , Bjorn Helgaas , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org QW5kcmV3LAoKT24gU2F0LCBKdWwgMjAsIDIwMTMgYXQgMDc6Mzg6NDdQTSArMDIwMCwgQW5kcmV3 IEx1bm4gd3JvdGU6Cj4gT24gU2F0LCBKdWwgMjAsIDIwMTMgYXQgMDY6NTg6NTVQTSArMDIwMCwg QW5kcmV3IEx1bm4gd3JvdGU6Cj4gPiBPbiBNb24sIEp1bCAxNSwgMjAxMyBhdCAxMTo1NzoyOUFN IC0wMzAwLCBFemVxdWllbCBHYXJjaWEgd3JvdGU6Cj4gPiA+IEhlcmUncyB0aGUgbmV3IE1CdXMg RFQgYmluZGluZywgaW1wbGVtZW50aW5nIHRoZSBjaGFuZ2VzIHByb3Bvc2VkCj4gPiA+IGJ5IFRo b21hcyB3aGVuIHdlIGRpc2N1c3NlZCB0aGUgcHJldmlvdXMgcGF0Y2hzZXQ6Cj4gPiA+IAo+ID4g PiAgIGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvYXJtLWtlcm5lbC9tc2cyNTcxNzAuaHRt bAo+ID4gPiAKPiA+ID4gQXMgZmFyIGFzIEkga25vdywgdGhpcyByb3VuZCBmaXhlcyAqYWxsKiB0 aGUgY29uY2VybnMgcmFpc2VkIGluIHRoZSBwYXN0Cj4gPiA+IGFuZCB0aGVyZWZvcmUgSSdkIGxp a2UgdG8gZ2V0IEFja2VkLWJ5J3MgZnJvbSBhbGwgdGhlIHBhcnRpZXMgaW52b2x2ZWQKPiA+ID4g b24gdGhlIHJlc3BlY3RpdmUgcGF0Y2hlcywgYW5kIHBhcnRpY3VsYXJseSBmb3IgdGhlIERUIGJp bmRpbmcuCj4gPiA+IAo+ID4gPiBJZiB0aGVyZSdzIGFueXRoaW5nIGxlZnQgdG8gcmV2aWV3LCB3 ZSdsbCBiZSBnbGFkIHRvIGZpeCBpdCBxdWlja2x5LAo+ID4gPiBzbyBkb24ndCBoZXNpdGF0ZSBp biBwcm92aWRpbmcgeW91ciBmZWVkYmFjayEKPiA+ID4gCj4gPiA+IEknbSBzdXJlIG1hbnkgb2Yg eW91IGFyZSBkeWluZyB0byB0ZXN0IHRoaXMgbmV3IE1CdXMgdGhpbmcsIHNvIHRvIG1ha2UKPiA+ ID4gaXQgZWFzaWVyIGZvciB0aG9zZSBjb3VyYWdlb3VzIGVub3VnaCwgSSd2ZSBwdXNoZWQgYSBw dWJsaWMgYnJhbmNoOgo+ID4gPiAKPiA+ID4gICBodHRwczovL2dpdGh1Yi5jb20vTUlTTC1FQlUt U3lzdGVtLVNXL21haW5saW5lLXB1YmxpYy90cmVlL21hcnZlbGwtbXZlYnUtbWJ1cy12Nwo+ID4g Cj4gPiBJIGp1c3QgdHJpZWQgdGhpcyBpbiBteSBLaXJrd29vZCBRTkFQLgo+ID4gCj4gPiBVbmNv bXByZXNzaW5nIExpbnV4Li4uIGRvbmUsIGJvb3RpbmcgdGhlIGtlcm5lbC4KPiA+IEJvb3Rpbmcg TGludXggb24gcGh5c2ljYWwgQ1BVIDB4MAo+ID4gTGludXggdmVyc2lvbiAzLjExLjAtcmMxLTAw MDIyLWc0NGU4YzM5IChsdW5uQGxvbmRvLmx1bm4uY2gpIChnY2MgdmVyc2lvbiA0LjMuNDMKPiA+ IENQVTogRmVyb2Nlb24gODhGUjEzMSBbNTYyNTEzMTFdIHJldmlzaW9uIDEgKEFSTXY1VEUpLCBj cj0wMDA1Mzk3Nwo+ID4gQ1BVOiBWSVZUIGRhdGEgY2FjaGUsIFZJVlQgaW5zdHJ1Y3Rpb24gY2Fj aGUKPiA+IE1hY2hpbmU6IE1hcnZlbGwgS2lya3dvb2QgKEZsYXR0ZW5lZCBEZXZpY2UgVHJlZSks IG1vZGVsOiBRTkFQIFRTMjE5IGZhbWlseQo+ID4gYm9vdGNvbnNvbGUgW2Vhcmx5Y29uMF0gZW5h YmxlZAo+ID4gTWVtb3J5IHBvbGljeTogRUNDIGRpc2FibGVkLCBEYXRhIGNhY2hlIHdyaXRlYmFj awo+ID4gQnVpbHQgMSB6b25lbGlzdHMgaW4gWm9uZSBvcmRlciwgbW9iaWxpdHkgZ3JvdXBpbmcg b24uICBUb3RhbCBwYWdlczogMTMwMDQ4Cj4gPiBLZXJuZWwgY29tbWFuZCBsaW5lOiByb290PS9k ZXYvc2RhMiBjb25zb2xlPXR0eVMwLDExNTIwMCBlYXJseXByaW50awo+ID4gUElEIGhhc2ggdGFi bGUgZW50cmllczogMjA0OCAob3JkZXI6IDEsIDgxOTIgYnl0ZXMpCj4gPiBEZW50cnkgY2FjaGUg aGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDYsIDI2MjE0NCBieXRlcykKPiA+IElu b2RlLWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMzI3NjggKG9yZGVyOiA1LCAxMzEwNzIgYnl0 ZXMpCj4gPiBNZW1vcnk6IDUxMzI2OEsvNTI0Mjg4SyBhdmFpbGFibGUgKDQyNDdLIGtlcm5lbCBj b2RlLCAyNDFLIHJ3ZGF0YSwgMTE0OEsgcm9kYXRhKQo+ID4gVmlydHVhbCBrZXJuZWwgbWVtb3J5 IGxheW91dDoKPiA+ICAgICB2ZWN0b3IgIDogMHhmZmZmMDAwMCAtIDB4ZmZmZjEwMDAgICAoICAg NCBrQikKPiA+ICAgICBmaXhtYXAgIDogMHhmZmYwMDAwMCAtIDB4ZmZmZTAwMDAgICAoIDg5NiBr QikKPiA+ICAgICB2bWFsbG9jIDogMHhlMDgwMDAwMCAtIDB4ZmYwMDAwMDAgICAoIDQ4OCBNQikK PiA+ICAgICBsb3dtZW0gIDogMHhjMDAwMDAwMCAtIDB4ZTAwMDAwMDAgICAoIDUxMiBNQikKPiA+ ICAgICBtb2R1bGVzIDogMHhiZjAwMDAwMCAtIDB4YzAwMDAwMDAgICAoICAxNiBNQikKPiA+ICAg ICAgIC50ZXh0IDogMHhjMDAwODAwMCAtIDB4YzA1NGQwNTAgICAoNTM5NyBrQikKPiA+ICAgICAg IC5pbml0IDogMHhjMDU0ZTAwMCAtIDB4YzA1NzY1MjAgICAoIDE2MiBrQikKPiA+ICAgICAgIC5k YXRhIDogMHhjMDU3ODAwMCAtIDB4YzA1YjQ0MjAgICAoIDI0MiBrQikKPiA+ICAgICAgICAuYnNz IDogMHhjMDViNDQyMCAtIDB4YzA2NGUxMDQgICAoIDYxNiBrQikKPiA+IFNMVUI6IEhXYWxpZ249 MzIsIE9yZGVyPTAtMywgTWluT2JqZWN0cz0wLCBDUFVzPTEsIE5vZGVzPTEKPiA+IFByZWVtcHRp YmxlIGhpZXJhcmNoaWNhbCBSQ1UgaW1wbGVtZW50YXRpb24uCj4gPiBOUl9JUlFTOjExNAo+ID4g c2NoZWRfY2xvY2s6IDMyIGJpdHMgYXQgMjAwTUh6LCByZXNvbHV0aW9uIDVucywgd3JhcHMgZXZl cnkgMjE0NzRtcwo+ID4gQ29uc29sZTogY29sb3VyIGR1bW15IGRldmljZSA4MHgzMAo+ID4gQ2Fs aWJyYXRpbmcgZGVsYXkgbG9vcC4uLiAxNTg3LjYwIEJvZ29NSVBTIChscGo9NzkzODA0OCkKPiA+ IHBpZF9tYXg6IGRlZmF1bHQ6IDMyNzY4IG1pbmltdW06IDMwMQo+ID4gTW91bnQtY2FjaGUgaGFz aCB0YWJsZSBlbnRyaWVzOiA1MTIKPiA+IENQVTogVGVzdGluZyB3cml0ZSBidWZmZXIgY29oZXJl bmN5OiBvawo+ID4gU2V0dGluZyB1cCBzdGF0aWMgaWRlbnRpdHkgbWFwIGZvciAweGMwNDBlODg4 IC0gMHhjMDQwZThjNAo+ID4gcGluY3RybCBjb3JlOiBpbml0aWFsaXplZCBwaW5jdHJsIHN1YnN5 c3RlbQo+ID4gcmVndWxhdG9yLWR1bW15OiBubyBwYXJhbWV0ZXJzCj4gPiBORVQ6IFJlZ2lzdGVy ZWQgcHJvdG9jb2wgZmFtaWx5IDE2Cj4gPiBETUE6IHByZWFsbG9jYXRlZCAyNTYgS2lCIHBvb2wg Zm9yIGF0b21pYyBjb2hlcmVudCBhbGxvY2F0aW9ucwo+ID4gS2lya3dvb2Q6IE1WODhGNjI4Mi1S ZXYtQTAsIFRDTEs9MjAwMDAwMDAwLgo+ID4gRmVyb2Nlb24gTDI6IEVuYWJsaW5nIEwyCj4gPiBG ZXJvY2VvbiBMMjogQ2FjaGUgc3VwcG9ydCBpbml0aWFsaXNlZC4KPiA+IGJpbzogY3JlYXRlIHNs YWIgPGJpby0wPiBhdCAwClsuLi5dCj4gPiBtdmVidS1wY2llIHBjaWUtY29udHJvbGxlci4xOiBQ Q0llMC4wOiBjYW5ub3QgZ2V0IHRndC9hdHRyIGZvciBtZW0gd2luZG93Cj4gPiBtdmVidS1wY2ll IHBjaWUtY29udHJvbGxlci4xOiBQQ0llMS4wOiBjYW5ub3QgZ2V0IHRndC9hdHRyIGZvciBtZW0g d2luZG93ClsuLi5dCj4gCj4gQW55IGlkZWFzPwo+IAoKVGhlIHBhdGNoc2V0IHdvcmtzIG9ubHkg Zm9yIEFybWFkYSAzNzAgYW5kIEFybWFkYSBYUCBTb0MsIG5vdCBmb3IgS2lya3dvb2QuCkZvciBz b21lIHJlYXNvbiBJIHdhcyBjb21wbGV0ZWx5IHN1cmUgdGhlcmUgd2Fzbid0IGFueSBEVC1lbmFi bGVkIEtpcmt3b29kCmJvYXJkcyB3aXRoIFBDSWUgc3VwcG9ydC4KCkkgYXBvbG9naXplIGZvciBu b3Qgbm90aWNpbmcgdGhpcyBiZWZvcmUhCgpNeSBwbGFuIHdhcyB0byBnZXQgdGhpcyBwYXRjaHNl dCBhY2tlZC9tZXJnZWQgYW5kIHRoZW4gYWRkIE1CdXMgRFQgdG8gS2lya3dvb2QuClRoZSByZWFz b24gZm9yIHRoaXMgaXMgdGhhdCBpdCdzIGEgc2ltcGxlIGNoYW5nZSwgYnV0IHByb2JhYmx5ICp2 ZXJ5KiBpbnRydXNpdmUKb24gdGhlIERUUyBmaWxlcy4KT2YgY291cnNlLCB0aGlzIHBsYW4gd2Fz IGJhc2VkIG9uIHRoZSBhc3N1bXB0aW9uIHRoYXQgdGhlIHdhc24ndCBicmVha2luZwphbnl0aGlu Zy4KCkhvd2V2ZXIsIG5vdyBJIGd1ZXNzIHRoZXJlJ3Mgbm8gb3RoZXIgc29sdXRpb24gdGhhbiBh ZGRpbmcgS2lya3dvb2QgdG8gdGhlCnBhdGNoc2V0LiBTbyB1bmxlc3MgYW55b25lIGhhcyBhbnkg YmV0dGVyIGlkZWEsIEknbGwgYmUgc2VuZGluZyBhIHY4LgoKVGhhbmtzIGFnYWluIGZvciB0aGUg dGVzdCEKLS0gCkV6ZXF1aWVsIEdhcmPDrWEsIEZyZWUgRWxlY3Ryb25zCkVtYmVkZGVkIExpbnV4 LCBLZXJuZWwgYW5kIEFuZHJvaWQgRW5naW5lZXJpbmcKaHR0cDovL2ZyZWUtZWxlY3Ryb25zLmNv bQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZpY2V0 cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMu b3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0cmVlLWRpc2N1c3MK