All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/9] gcc/bfin: doesn't support --with-cpu defaults
Date: Sun, 21 Jul 2013 17:35:39 +0200	[thread overview]
Message-ID: <20130721173539.28707500@skate> (raw)
In-Reply-To: <1374324735-2286-2-git-send-email-gustavo@zacarias.com.ar>

Dear Gustavo Zacarias,

On Sat, 20 Jul 2013 09:52:07 -0300, Gustavo Zacarias wrote:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

> +# GCC doesn't support --with-cpu for bfin
> +ifeq ($(BR2_bfin),)
>  ifneq ($(call qstrip,$(BR2_GCC_TARGET_CPU)),)
>  ifneq ($(call qstrip,$(BR2_GCC_TARGET_CPU_REVISION)),)
>  HOST_GCC_COMMON_CONF_OPT += --with-cpu=$(call qstrip,$(BR2_GCC_TARGET_CPU)-$(BR2_GCC_TARGET_CPU_REVISION))
> @@ -166,6 +168,7 @@ else
>  HOST_GCC_COMMON_CONF_OPT += --with-cpu=$(call qstrip,$(BR2_GCC_TARGET_CPU))
>  endif
>  endif
> +endif

This looks odd because the BR2_GCC_TARGET_CPU_REVISION thing was added
by Sonic Zhang, see 66d41890ec2b76189bcd427a0cc3966ff56f9712. So it is
specifically useful on Blackfin. Maybe just with Analog Devices
toolchains, I don't know. But clearly, removing that for Blackfin seems
wrong.


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-07-21 15:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-20 12:52 [Buildroot] [PATCH 0/9] Fix internal blackfin toolchain Gustavo Zacarias
2013-07-20 12:52 ` [Buildroot] [PATCH 1/9] gcc/bfin: doesn't support --with-cpu defaults Gustavo Zacarias
2013-07-21 15:35   ` Thomas Petazzoni [this message]
2013-07-21 16:26     ` Gustavo Zacarias
2013-07-20 12:52 ` [Buildroot] [PATCH 2/9] uclibc/bfin: only supports linuxthreads.old Gustavo Zacarias
2013-07-20 12:58   ` Yann E. MORIN
2013-07-27 14:21   ` Thomas Petazzoni
2013-07-20 12:52 ` [Buildroot] [PATCH 3/9] uclibc: make target utils optional Gustavo Zacarias
2013-07-20 13:08   ` Yann E. MORIN
2013-07-20 12:52 ` [Buildroot] [PATCH 4/9] gcc/bfin: 4.{6,7,8}.x are broken Gustavo Zacarias
2013-07-20 12:52 ` [Buildroot] [PATCH 5/9] uclibc: use builtin startfiles target Gustavo Zacarias
2013-07-20 12:52 ` [Buildroot] [PATCH 6/9] uclibc/bfin: set the appropiate binfmt in the configuration Gustavo Zacarias
2013-07-20 12:52 ` [Buildroot] [PATCH 7/9] uclibc/bfin: don't install host utils if not FDPIC Gustavo Zacarias
2013-07-20 12:52 ` [Buildroot] [PATCH 8/9] blackfin: set GNU_TARGET_NAME accordingly Gustavo Zacarias
2013-07-21 15:38   ` Thomas Petazzoni
2013-07-21 16:32     ` Gustavo Zacarias
2013-07-27 14:22   ` Thomas Petazzoni
2013-07-20 12:52 ` [Buildroot] [PATCH 9/9] gcc/mudflap: disable for blackfin, it doesn't build Gustavo Zacarias
2013-07-27 14:23 ` [Buildroot] [PATCH 0/9] Fix internal blackfin toolchain Thomas Petazzoni
2013-07-27 14:35   ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130721173539.28707500@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.