From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: XFS mailing list <xfs@oss.sgi.com>
Subject: Re: Subject: [PATCH v2] xfs: Initialize all quota inodes to be NULLFSINO
Date: Mon, 22 Jul 2013 14:08:44 -0500 [thread overview]
Message-ID: <20130722190844.GC3111@sgi.com> (raw)
In-Reply-To: <1374273175.8941.2079.camel@chandra-dt.ibm.com>
On Fri, Jul 19, 2013 at 05:32:55PM -0500, Chandra Seetharaman wrote:
> Change from previous version:
> - Added the additional comments that Dave wanted.
>
> -------------
> mkfs doesn't initialize the quota inodes to NULLFSINO as it does for the
> other internal inodes. This leads to two in-core values (0 and NULLFSINO)
> to be checked against, to make sure if a quota inode is valid.
>
> Solve that problem by initializing the in-core values of all quotaino
> values to NULLFSINO if they are 0 in the disk.
>
> Note that these values are not written back to on-disk superblock unless
> some quota is enabled on the filesystem. Even in that case sb_pquotino is
> written to disk only if the on-disk superblock supports pquotino
>
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-07-22 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 22:32 Subject: [PATCH v2] xfs: Initialize all quota inodes to be NULLFSINO Chandra Seetharaman
2013-07-22 19:08 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722190844.GC3111@sgi.com \
--to=bpm@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.