From: Mark Brown <broonie@kernel.org>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jean-Francois Moine <moinejf@free.fr>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [alsa-devel] [PATCH] ARM: kirkwood: enable S/PDIF
Date: Tue, 23 Jul 2013 14:26:28 +0100 [thread overview]
Message-ID: <20130723132628.GD9858@sirena.org.uk> (raw)
In-Reply-To: <51EE8158.4050300@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Tue, Jul 23, 2013 at 03:12:56PM +0200, Sebastian Hesselbarth wrote:
> the mask that is changed in the patch is what will be written
> into i2s controller's registers. So, if there is no S/PDIF in that
> specific controller that bit can possibly have a different meaning.
> Also, enabling both I2S playback and SPDIF playback can cause the
> controller to behave differently.
Oh, so it will - I glanced through it and misread, sorry. If it just
makes the enabling of S/PDIF mode conditional on DAI format that'd cover
it.
> I share Russell's concern about it and would rather like to use
> multiple codecs per DAI (DPCM) for that. I see Daniel Mack picked
> that up again, maybe he submits something soon.
Well, that'd be ideal and is going to be needed for any hardware which
has both wired up in parallel but a simpler either/or thing doesn't seem
like a problem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-23 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:23 [PATCH] ARM: kirkwood: enable S/PDIF Jean-Francois Moine
2013-07-23 8:43 ` Russell King - ARM Linux
2013-07-23 8:43 ` Russell King - ARM Linux
2013-07-23 13:06 ` Mark Brown
2013-07-23 13:06 ` Mark Brown
2013-07-23 13:12 ` Sebastian Hesselbarth
2013-07-23 13:12 ` [alsa-devel] " Sebastian Hesselbarth
2013-07-23 13:26 ` Mark Brown [this message]
2013-07-23 13:36 ` Russell King - ARM Linux
2013-07-23 13:36 ` [alsa-devel] " Russell King - ARM Linux
2013-07-23 13:21 ` Russell King - ARM Linux
2013-07-23 13:21 ` Russell King - ARM Linux
2013-07-23 13:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723132628.GD9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=moinejf@free.fr \
--cc=rob.herring@calxeda.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.