From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 01/13] ACPI/IPMI: Fix potential response buffer overflow Date: Tue, 23 Jul 2013 07:54:19 -0700 Message-ID: <20130723145419.GA12065@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Corey Minyard , Zhao Yakui , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net List-Id: linux-acpi@vger.kernel.org On Tue, Jul 23, 2013 at 04:08:59PM +0800, Lv Zheng wrote: > This patch enhances sanity checks on message size to avoid potential buffer > overflow. > > The kernel IPMI message size is IPMI_MAX_MSG_LENGTH(272 bytes) while the > ACPI specification defined IPMI message size is 64 bytes. The difference > is not handled by the original codes. This may cause crash in the response > handling codes. > This patch fixes this gap and also combines rx_data/tx_data to use single > data/len pair since they need not be seperated. > > Signed-off-by: Lv Zheng > Reviewed-by: Huang Ying > --- > drivers/acpi/acpi_ipmi.c | 100 ++++++++++++++++++++++++++++------------------ > 1 file changed, 61 insertions(+), 39 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. Same goes for the other patches you sent in this thread...