All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Dave Chinner <dchinner@redhat.com>,
	Mark Tinguely <tinguely@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH v2] xfs: di_flushiter considered harmful
Date: Tue, 23 Jul 2013 10:07:24 -0500	[thread overview]
Message-ID: <20130723150724.GH3111@sgi.com> (raw)
In-Reply-To: <20130723104259.GB360@x4>

Hi Markus,

On Tue, Jul 23, 2013 at 12:42:59PM +0200, Markus Trippelsdorf wrote:
> On 2013.07.22 at 14:48 -0500, Mark Tinguely wrote:
> > On 07/22/13 10:15, Markus Trippelsdorf wrote:
> > > On 2013.07.22 at 09:40 -0500, Mark Tinguely wrote:
> > >> On 07/22/13 06:07, Markus Trippelsdorf wrote:
> > >>> On 2013.07.22 at 20:18 +1000, Dave Chinner wrote:
> > >> It seems to me that since we cannot fix this for inode 1/2, then besides
> > >> this patch we have to revert patch cca9f93a52d and make it inode 3+ /
> > >> superblock 5+ (crc) dependent.
> > >
> > > Which is exactly what the hunk I've posted does.
> > >
> > > Here's the combined patch:
> > 
> > Following Dave's instruction to recreate this problem, your patch works 
> > with an inode 2 and inode 3 (once I remembered to load the module before 
> > recovery). Dave's patch was successful on inode 3 - again after I 
> > remembered to load the module before recovery.
> > 
> > Whomever makes the formal patch, consider it reviewed-by me.
> 
> To get this patch to Linus ASAP, here's the combined patch again. 
> Please apply.
> Thanks.

I'd prefer to have Dave take another look at the combined patch before pulling
this in.  Even so, we shouldn't have any trouble getting this into -rc3.

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-07-23 15:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 10:18 [PATCH] xfs: di_flushiter considered harmful Dave Chinner
2013-07-22 11:07 ` Markus Trippelsdorf
2013-07-22 14:40   ` Mark Tinguely
2013-07-22 15:15     ` Markus Trippelsdorf
2013-07-22 16:37       ` Mark Tinguely
2013-07-22 19:48       ` Mark Tinguely
2013-07-23 10:42         ` [PATCH v2] " Markus Trippelsdorf
2013-07-23 15:07           ` Ben Myers [this message]
2013-07-23 15:56             ` Markus Trippelsdorf
2013-07-22 22:56   ` [PATCH] " Dave Chinner
2013-07-23  1:28     ` Markus Trippelsdorf
2013-07-23  4:49       ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723150724.GH3111@sgi.com \
    --to=bpm@sgi.com \
    --cc=dchinner@redhat.com \
    --cc=markus@trippelsdorf.de \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.