All of lore.kernel.org
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Date: Tue, 23 Jul 2013 10:01:53 -0700	[thread overview]
Message-ID: <20130723170153.GA27761@codeaurora.org> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433EEB180B@DBDE04.ent.ti.com>

On 07/20, Bedia, Vaibhav wrote:
> Hi,
> 
> On Sat, Jul 06, 2013 at 05:09:33, Stephen Boyd wrote:
> > In a uniprocessor implementation the interrupt processor targets
> > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
> > gic_get_cpumask() will print a critical message saying
> > 
> >  GIC CPU mask not found - kernel will fail to boot.
> > 
> > if these registers all read as zero, but there won't actually be
> > a problem on uniprocessor systems and the kernel will boot just
> > fine. Skip this check if we're running a UP kernel or if we
> > detect that the hardware only supports a single processor.
> > 
> > Cc: Nicolas Pitre <nico@linaro.org>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > 
> > Maybe we should just drop the check entirely? It looks like it may
> > just be debug code that won't ever trigger in practice, even on the
> > 11MPCore that caused this code to be introduced.
> > 
> 
> Apologies if I missed v2 of this patch if there was one. I could not
> locate it in my inbox or the list archives.
> 
> We have a yet to be released single-core A9 MPCore system (AM437x) which
> needs to co-exist in omap2plus_defconfig wherein NR_CPUS is set to 2. 
> This currently leads to the "GIC CPU mask not found..." being printed
> twice during bootup. If the check is really some debug code, can it be
> completely dropped?

I have sent both versions of the patch in hopes that one or the
other will be accepted. Either way works for me.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: "Bedia, Vaibhav" <vaibhav.bedia@ti.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Nicolas Pitre <nico@linaro.org>
Subject: Re: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Date: Tue, 23 Jul 2013 10:01:53 -0700	[thread overview]
Message-ID: <20130723170153.GA27761@codeaurora.org> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433EEB180B@DBDE04.ent.ti.com>

On 07/20, Bedia, Vaibhav wrote:
> Hi,
> 
> On Sat, Jul 06, 2013 at 05:09:33, Stephen Boyd wrote:
> > In a uniprocessor implementation the interrupt processor targets
> > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
> > gic_get_cpumask() will print a critical message saying
> > 
> >  GIC CPU mask not found - kernel will fail to boot.
> > 
> > if these registers all read as zero, but there won't actually be
> > a problem on uniprocessor systems and the kernel will boot just
> > fine. Skip this check if we're running a UP kernel or if we
> > detect that the hardware only supports a single processor.
> > 
> > Cc: Nicolas Pitre <nico@linaro.org>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > 
> > Maybe we should just drop the check entirely? It looks like it may
> > just be debug code that won't ever trigger in practice, even on the
> > 11MPCore that caused this code to be introduced.
> > 
> 
> Apologies if I missed v2 of this patch if there was one. I could not
> locate it in my inbox or the list archives.
> 
> We have a yet to be released single-core A9 MPCore system (AM437x) which
> needs to co-exist in omap2plus_defconfig wherein NR_CPUS is set to 2. 
> This currently leads to the "GIC CPU mask not found..." being printed
> twice during bootup. If the check is really some debug code, can it be
> completely dropped?

I have sent both versions of the patch in hopes that one or the
other will be accepted. Either way works for me.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-07-23 17:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 23:39 [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system Stephen Boyd
2013-07-05 23:39 ` Stephen Boyd
2013-07-12 11:13 ` Javi Merino
2013-07-12 11:13   ` Javi Merino
2013-07-12 12:10   ` Stephen Boyd
2013-07-12 12:10     ` Stephen Boyd
2013-07-17 21:53     ` Stephen Boyd
2013-07-17 21:53       ` Stephen Boyd
2013-07-17 22:34       ` Nicolas Pitre
2013-07-17 22:34         ` Nicolas Pitre
2013-07-17 22:36         ` Stephen Boyd
2013-07-17 22:36           ` Stephen Boyd
2013-07-17 22:53           ` Nicolas Pitre
2013-07-17 22:53             ` Nicolas Pitre
2013-07-17 23:06             ` Stephen Boyd
2013-07-17 23:06               ` Stephen Boyd
2013-08-22 18:43               ` Stephen Boyd
2013-08-22 18:43                 ` Stephen Boyd
2013-08-22 18:59                 ` Nicolas Pitre
2013-08-22 18:59                   ` Nicolas Pitre
2013-08-23  4:35                   ` Stephen Boyd
2013-08-23  4:35                     ` Stephen Boyd
2013-08-23  4:51                     ` Nicolas Pitre
2013-08-23  4:51                       ` Nicolas Pitre
2013-08-23  9:15                       ` Russell King - ARM Linux
2013-08-23  9:15                         ` Russell King - ARM Linux
2013-07-20  7:27 ` Bedia, Vaibhav
2013-07-20  7:27   ` Bedia, Vaibhav
2013-07-23 17:01   ` Stephen Boyd [this message]
2013-07-23 17:01     ` Stephen Boyd
  -- strict thread matches above, loose matches on Subject: below --
2015-01-31  0:43 Stephen Boyd
2015-01-31  0:43 ` Stephen Boyd
2015-01-31  7:09 ` Felipe Balbi
2015-01-31  7:09   ` Felipe Balbi
2015-01-31  7:09   ` Felipe Balbi
2015-02-12  3:51   ` Nishanth Menon
2015-02-12  3:51     ` Nishanth Menon
2015-02-12  3:51     ` Nishanth Menon
2015-02-01 21:25 ` Stefan Agner
2015-02-01 21:25   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723170153.GA27761@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.