From: Artem Savkov <artem.savkov@gmail.com>
To: dchinner@redhat.com, glommer@openvz.org
Cc: daniel.vetter@ffwll.ch, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size
Date: Tue, 23 Jul 2013 23:29:49 +0400 [thread overview]
Message-ID: <20130723192949.GA3786@thinkpad.lan> (raw)
In-Reply-To: <1374607086-6761-1-git-send-email-artem.savkov@gmail.com>
On Tue, Jul 23, 2013 at 11:18:06PM +0400, Artem Savkov wrote:
> nr_to_scan needs to be (unsigned) long, not int, otherwise we get negative
> values on 32bit systems during shrink resulting in lots of messages like one
> below.
>
> [ 4078.989603] shrink_slab: i915_gem_inactive_scan+0x0/0xc0 negative objects to delete nr=-289580136
>
> Introduced in "drivers: convert shrinkers to new count/scan API"
> (383e4f4a4cdeb2dd552e90811089bcb4d41eb32e in linux-next.git)
Sorry, looks like my analysis was wrong, I can still see the issue with this
patch.
--
Regards,
Artem
prev parent reply other threads:[~2013-07-23 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 19:18 [PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size Artem Savkov
2013-07-23 19:29 ` Artem Savkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723192949.GA3786@thinkpad.lan \
--to=artem.savkov@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dchinner@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=glommer@openvz.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.