From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Alexander Z Lam <azl@google.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
David Sharp <dhsharp@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Vaibhav Nagarnaik <vnagarnaik@google.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/6] tracing: open/delete fixes
Date: Tue, 23 Jul 2013 22:58:54 +0200 [thread overview]
Message-ID: <20130723205854.GA9036@redhat.com> (raw)
Hello.
Untested again, only for review. Sorry, I know this is annoying.
Will try to test tomorrow.
The only essential change is that "clear d_subdirs->i_private"
comes as a last patch, this needs the additional comment in the
changelogs of 1-4 but avoids the temporary complications.
I am sending this series right now because:
- I promised to do this today ;)
- Whatever I do, correctness-wise this needs your review
anyway.
- Even if correct, the very intent needs an ack from Masami
who seems to disagree with this approach.
This series shifts the validation from f_op->open() (which
currently doesn't work) to ->read/write.
While I personally think this makes more sense (simpler
and does not block rmdir/event_remove), I understand that
this is subjective, so I won't argue too much if you prefer
to add the additional ref-counts instead.
>From 6/6:
Note: this doesn't not fix other problems, event_remove() can
destroy the active ftrace_event_call, we need more changes but
those changes are completely orthogonal.
Oleg.
kernel/trace/trace.h | 4 +-
kernel/trace/trace_events.c | 176 ++++++++++++++++++------------------
kernel/trace/trace_events_filter.c | 21 ++---
3 files changed, 99 insertions(+), 102 deletions(-)
next reply other threads:[~2013-07-23 21:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 20:58 Oleg Nesterov [this message]
2013-07-23 20:59 ` [PATCH 1/6] tracing: Turn event/id->i_private into call->event.type Oleg Nesterov
2013-07-24 20:13 ` Steven Rostedt
2013-07-25 14:26 ` Oleg Nesterov
2013-07-23 20:59 ` [PATCH 2/6] tracing: Change event_enable/disable_read() to verify i_private != NULL Oleg Nesterov
2013-07-24 19:37 ` Steven Rostedt
2013-07-23 20:59 ` [PATCH 3/6] tracing: Change event_filter_read/write " Oleg Nesterov
2013-07-24 19:52 ` Steven Rostedt
2013-07-23 20:59 ` [PATCH 4/6] tracing: Change f_start() to take event_mutex and " Oleg Nesterov
2013-07-23 20:59 ` [PATCH 5/6] tracing: Introduce remove_event_file_dir() Oleg Nesterov
2013-07-24 20:01 ` Steven Rostedt
2013-07-23 20:59 ` [PATCH 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private Oleg Nesterov
2013-07-24 20:08 ` Steven Rostedt
2013-07-25 14:18 ` Oleg Nesterov
2013-07-24 18:46 ` [PATCH 0/6] tracing: open/delete fixes Oleg Nesterov
2013-07-25 16:56 ` Oleg Nesterov
2013-07-25 19:27 ` PATCH? debugfs_remove_recursive() must not rely on list_empty(d_subdirs) Oleg Nesterov
2013-07-25 20:04 ` Oleg Nesterov
2013-07-25 23:43 ` Greg Kroah-Hartman
2013-07-26 15:11 ` [PATCH 0/1] debugfs: " Oleg Nesterov
2013-07-26 15:12 ` Oleg Nesterov
2013-07-26 15:14 ` Oleg Nesterov
2013-07-26 15:12 ` [PATCH 1/1] " Oleg Nesterov
2013-07-26 17:38 ` Greg Kroah-Hartman
2013-07-26 18:40 ` Steven Rostedt
2013-07-26 15:30 ` [PATCH 0/1] " Steven Rostedt
2013-07-26 16:28 ` Greg Kroah-Hartman
2013-07-26 17:38 ` Greg Kroah-Hartman
2013-07-26 10:24 ` Re: PATCH? " Masami Hiramatsu
2013-07-26 14:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723205854.GA9036@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=azl@google.com \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.