All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aldo Iljazi <neonsync1@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue.
Date: Tue, 23 Jul 2013 14:50:36 -0700	[thread overview]
Message-ID: <20130723215036.GA5367@kroah.com> (raw)
In-Reply-To: <1373301228-18694-1-git-send-email-neonsync1@gmail.com>

On Mon, Jul 08, 2013 at 07:33:48PM +0300, Aldo Iljazi wrote:
> Fixed a coding style issue, specifically checkpatch.pl complain:
> ossiRelease.c:27: WARNING: line over 80 characters
> 
> Signed-off-by: Aldo Iljazi <neonsync1@gmail.com>
> ---
>  drivers/staging/cxt1e1/ossiRelease.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/cxt1e1/ossiRelease.c b/drivers/staging/cxt1e1/ossiRelease.c
> index f17a902..35575bf 100644
> --- a/drivers/staging/cxt1e1/ossiRelease.c
> +++ b/drivers/staging/cxt1e1/ossiRelease.c
> @@ -24,6 +24,7 @@
>   *-----------------------------------------------------------------------------
>   */
>  
> -char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B,  Copyright (c) 2008 One Stop Systems$";
> +char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B,  "
> +"Copyright (c) 2008 One Stop Systems$";

No, please fix this correctly, by just removing it entirely, it's not
needed.

thanks,

greg k-h

       reply	other threads:[~2013-07-23 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1373301228-18694-1-git-send-email-neonsync1@gmail.com>
2013-07-23 21:50 ` Greg KH [this message]
2013-07-08 16:40 [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue Aldo Iljazi
2013-07-08 16:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723215036.GA5367@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neonsync1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.