Re: [PATCH v2 06/10] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages()

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Mon, Jul 22, 2013 at 05:36:27PM +0900, Joonsoo Kim wrote:
>If list is empty, list_for_each_entry_safe() doesn't do anything.
>So, this check is redundant. Remove it.
>
>Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>

Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

>diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>index 3ac0a6f..7ca8733 100644
>--- a/mm/hugetlb.c
>+++ b/mm/hugetlb.c
>@@ -1017,11 +1017,8 @@ free:
> 	spin_unlock(&hugetlb_lock);
>
> 	/* Free unnecessary surplus pages to the buddy allocator */
>-	if (!list_empty(&surplus_list)) {
>-		list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
>-			put_page(page);
>-		}
>-	}
>+	list_for_each_entry_safe(page, tmp, &surplus_list, lru)
>+		put_page(page);
> 	spin_lock(&hugetlb_lock);
>
> 	return ret;
>-- 
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>