From: Mark Brown <broonie@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Robin Gong <b38343@freescale.com>,
shawn.guo@linaro.org, grant.likely@linaro.org,
rob.herring@calxeda.com, rob@landley.net, lgirdwood@gmail.com,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver
Date: Wed, 24 Jul 2013 10:42:28 +0100 [thread overview]
Message-ID: <20130724094228.GY9858@sirena.org.uk> (raw)
In-Reply-To: <20130724083041.GC4332@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Wed, Jul 24, 2013 at 10:30:41AM +0200, Steffen Trumtrar wrote:
> On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote:
>
> static struct regulator_ops pfuze100_fixed_regulator_ops = {
> .list_voltage = regulator_list_voltage_linear,
> + .set_voltage_sel = regulator_set_voltage_sel_regmap,
> };
This doesn't make much sense, you're adding a set voltage operation to a
fixed voltage regulator...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-24 9:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 9:17 [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver Robin Gong
2013-07-21 9:17 ` Robin Gong
2013-07-22 9:11 ` Shawn Guo
2013-07-22 9:11 ` Shawn Guo
2013-07-22 10:39 ` Robin Gong
2013-07-22 10:39 ` Robin Gong
2013-07-22 12:46 ` Shawn Guo
2013-07-22 12:46 ` Shawn Guo
2013-07-24 8:30 ` Steffen Trumtrar
2013-07-24 9:42 ` Mark Brown [this message]
2013-07-24 9:51 ` Steffen Trumtrar
2013-07-24 14:39 ` Mark Brown
2013-07-24 10:07 ` Robin Gong
2013-07-24 10:07 ` Robin Gong
2013-07-24 10:18 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724094228.GY9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b38343@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.trumtrar@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.