From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: Re: Re: [PATCH] ceph: Don't use ceph-sync-mode for synchronous-fs. Date: Wed, 24 Jul 2013 12:46:44 +0800 Message-ID: <201307241246395750351@gmail.com> References: <201306271556037311581@gmail.com>, <201307161949279533980@gmail.com> <201307240828220999500@gmail.com>, Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: sage Cc: ceph-devel , linux-kernel List-Id: ceph-devel.vger.kernel.org PkhpLA0KPg0KPlNvcnJ5IGZvciB0aGUgc2xvdyByZXZpZXcuICBUaGUgcGF0Y2ggbG9va3MgZ29v ZCwgYnV0IEkgaGF2ZSBhIGhhcmQgdGltZSANCj51bmRlcnN0YW5kaW5nIHlvdXIgY2hhbmdlbG9n Li4uIGlzIGl0IG9rYXkgaWYgSSBjaGFuZ2UgaXQgdG8gc29tZXRoaW5nIA0KPmxpa2U6DQo+DQo+ DQo+U2VuZGluZyByZWFkcyBhbmQgd3JpdGVzIHRocm91Z2ggdGhlIHN5bmMgcmVhZC93cml0ZSBw YXRocyBieXBhc3NlcyB0aGUgDQo+cGFnZSBjYWNoZSwgd2hpY2ggaXMgbm90IGV4cGVjdGVkIG9y IGdlbmVyYWxseSBhIGdvb2QgaWRlYS4gIFJlbW92aW5nIA0KPnRoZSB3cml0ZSBjaGVjayBpcyBz YWZlIGFzIHRoZXJlIGlzIGEgY29uZGl0aW9uYWwgdmZzX2ZzeW5jX3JhbmdlKCkgbGF0ZXIgDQo+ aW4gY2VwaF9haW9fd3JpdGUgdGhhdCBhbHJlYWR5IGNoZWNrcyBmb3IgdGhlIHNhbWUgZmxhZyAo dmlhIA0KPklTX1NZTkMoaW5vZGUpKS4NCj4NClZlcnkgZ29vZC4NCkl0J3MgbXkgZmF1bHQuIEkg d2lsbCBub3RpY2UgdGhlIG1lc3NhZ2UgbGF0ZXIuDQoNClRoYW5rcyAhDQpKaWFucGVuZyBNYQ0K Pj8NCj4NCj5UaGFua3MhDQo+c2FnZQ0KPg0KPg0KPk9uIFdlZCwgMjQgSnVsIDIwMTMsIG1hamlh bnBlbmcgd3JvdGU6DQo+DQo+PiBQaW5nDQo+PiA+SGkgc2FnZSwNCj4+ID4JSG93IGFib3V0IHRo aXMgcGF0Y2g/Q2FuIHlvdSBnaXZlIHNvbWUgYWR2aXNlbWVudD8NCj4+ID5UaGFua3MhDQo+PiA+ SmlhbnBlbmcgTWENCj4+ID4+QXQgbm93IGZvciBzeW5jaHJvbm91cy1mcywgYWxsIHdyaXRlLW9w ZXJhdGlvbnMgdXNlIGNlcGhfc3luY19tb2RlLg0KPj4gPj5CdXQgZm9yIHRoZSBmaWxlIHdoaWNo IG9wZW5lZCB3aXRoIE9fU1lOQywgaXQgZG9uJ3QgdXNlIHN5bmNfbW9kZS4NCj4+ID4+VGhlIGJl aGF2aW91ciBvZiB0aGVtIHNob3VsZCBiZSB0aGUgc2FtZS4NCj4+ID4+Rm9yIGZzIHdoaWNoIG1v dW50ZWQgdXNpbmcgJy1vIHN5bmMnLCBpdCB3YW50IGFsbCBJL08gdG8gdGhlIGZpbGVzeXN0ZW0N Cj4+ID4+c2hvdWxkIGJlIGRvbmUgc3luY2hyb25vdXNseS5CdXQgdGhlIGNlcGgtc3luYy1tb2Rl IGRvbid0IGJlIHN1aXRmdWwNCj4+ID4+Zm9yLkZvciBleGFtcGxlLHVzaW5nIGNlcGgtc3luYy1t b2RlIHRoZSBjb250ZW50IG9mIGZpbGUgZG9uJ3QgaGF2ZSBpbg0KPj4gPj5tZW1vcnkuVGhpcyB3 aWxsIGNhdXNlIHRoZSBmb2xsb3dpbmcgcmVhZCBvbmx5IGZyb20gb3NkIHJhdGhlciB0aGFuDQo+ PiA+Pm1lbW9yeS4NCj4+ID4+DQo+PiA+PlNpZ25lZC1vZmYtYnk6IEppYW5wZW5nIE1hIDxtYWpp YW5wZW5nQGdtYWlsLmNvbT4NCj4+ID4+LS0tDQo+PiA+PiBmcy9jZXBoL2ZpbGUuYyB8IDIgLS0N Cj4+ID4+IDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQ0KPj4gPj4NCj4+ID4+ZGlmZiAt LWdpdCBhL2ZzL2NlcGgvZmlsZS5jIGIvZnMvY2VwaC9maWxlLmMNCj4+ID4+aW5kZXggNjU2ZTE2 OS4uNDQ2NzBhZCAxMDA2NDQNCj4+ID4+LS0tIGEvZnMvY2VwaC9maWxlLmMNCj4+ID4+KysrIGIv ZnMvY2VwaC9maWxlLmMNCj4+ID4+QEAgLTY1OSw3ICs2NTksNiBAQCBhZ2FpbjoNCj4+ID4+IA0K Pj4gPj4gCWlmICgoZ290ICYgKENFUEhfQ0FQX0ZJTEVfQ0FDSEV8Q0VQSF9DQVBfRklMRV9MQVpZ SU8pKSA9PSAwIHx8DQo+PiA+PiAJICAgIChpb2NiLT5raV9maWxwLT5mX2ZsYWdzICYgT19ESVJF Q1QpIHx8DQo+PiA+Pi0JICAgIChpbm9kZS0+aV9zYi0+c19mbGFncyAmIE1TX1NZTkNIUk9OT1VT KSB8fA0KPj4gPj4gCSAgICAoZmktPmZsYWdzICYgQ0VQSF9GX1NZTkMpKQ0KPj4gPj4gCQkvKiBo bW0sIHRoaXMgaXNuJ3QgcmVhbGx5IGFzeW5jLi4uICovDQo+PiA+PiAJCXJldCA9IGNlcGhfc3lu Y19yZWFkKGZpbHAsIGJhc2UsIGxlbiwgcHBvcywgJmNoZWNrZW9mKTsNCj4+ID4+QEAgLTc2NCw3 ICs3NjMsNiBAQCByZXRyeV9zbmFwOg0KPj4gPj4gDQo+PiA+PiAJaWYgKChnb3QgJiAoQ0VQSF9D QVBfRklMRV9CVUZGRVJ8Q0VQSF9DQVBfRklMRV9MQVpZSU8pKSA9PSAwIHx8DQo+PiA+PiAJICAg IChpb2NiLT5raV9maWxwLT5mX2ZsYWdzICYgT19ESVJFQ1QpIHx8DQo+PiA+Pi0JICAgIChpbm9k ZS0+aV9zYi0+c19mbGFncyAmIE1TX1NZTkNIUk9OT1VTKSB8fA0KPj4gPj4gCSAgICAoZmktPmZs YWdzICYgQ0VQSF9GX1NZTkMpKSB7DQo+PiA+PiAJCW11dGV4X3VubG9jaygmaW5vZGUtPmlfbXV0 ZXgpOw0KPj4gPj4gCQl3cml0dGVuID0gY2VwaF9zeW5jX3dyaXRlKGZpbGUsIGlvdi0+aW92X2Jh c2UsIGNvdW50LA0KPj4gPj4tLSANCj4+ID4+MS44LjEuMg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424Ab3GXEqy (ORCPT ); Wed, 24 Jul 2013 00:46:54 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:32886 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887Ab3GXEqw (ORCPT ); Wed, 24 Jul 2013 00:46:52 -0400 Date: Wed, 24 Jul 2013 12:46:44 +0800 From: majianpeng To: sage Cc: ceph-devel , linux-kernel Reply-To: majianpeng Subject: Re: Re: [PATCH] ceph: Don't use ceph-sync-mode for synchronous-fs. References: <201306271556037311581@gmail.com>, <201307161949279533980@gmail.com> <201307240828220999500@gmail.com>, X-Priority: 3 X-GUID: 7FABF9DC-66BF-4D53-868E-1897418653CA X-Has-Attach: no X-Mailer: Foxmail 7.0.1.90[en] Mime-Version: 1.0 Message-ID: <201307241246395750351@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r6O4l1BT025552 >Hi, > >Sorry for the slow review. The patch looks good, but I have a hard time >understanding your changelog... is it okay if I change it to something >like: > > >Sending reads and writes through the sync read/write paths bypasses the >page cache, which is not expected or generally a good idea. Removing >the write check is safe as there is a conditional vfs_fsync_range() later >in ceph_aio_write that already checks for the same flag (via >IS_SYNC(inode)). > Very good. It's my fault. I will notice the message later. Thanks ! Jianpeng Ma >? > >Thanks! >sage > > >On Wed, 24 Jul 2013, majianpeng wrote: > >> Ping >> >Hi sage, >> > How about this patch?Can you give some advisement? >> >Thanks! >> >Jianpeng Ma >> >>At now for synchronous-fs, all write-operations use ceph_sync_mode. >> >>But for the file which opened with O_SYNC, it don't use sync_mode. >> >>The behaviour of them should be the same. >> >>For fs which mounted using '-o sync', it want all I/O to the filesystem >> >>should be done synchronously.But the ceph-sync-mode don't be suitful >> >>for.For example,using ceph-sync-mode the content of file don't have in >> >>memory.This will cause the following read only from osd rather than >> >>memory. >> >> >> >>Signed-off-by: Jianpeng Ma >> >>--- >> >> fs/ceph/file.c | 2 -- >> >> 1 file changed, 2 deletions(-) >> >> >> >>diff --git a/fs/ceph/file.c b/fs/ceph/file.c >> >>index 656e169..44670ad 100644 >> >>--- a/fs/ceph/file.c >> >>+++ b/fs/ceph/file.c >> >>@@ -659,7 +659,6 @@ again: >> >> >> >> if ((got & (CEPH_CAP_FILE_CACHE|CEPH_CAP_FILE_LAZYIO)) == 0 || >> >> (iocb->ki_filp->f_flags & O_DIRECT) || >> >>- (inode->i_sb->s_flags & MS_SYNCHRONOUS) || >> >> (fi->flags & CEPH_F_SYNC)) >> >> /* hmm, this isn't really async... */ >> >> ret = ceph_sync_read(filp, base, len, ppos, &checkeof); >> >>@@ -764,7 +763,6 @@ retry_snap: >> >> >> >> if ((got & (CEPH_CAP_FILE_BUFFER|CEPH_CAP_FILE_LAZYIO)) == 0 || >> >> (iocb->ki_filp->f_flags & O_DIRECT) || >> >>- (inode->i_sb->s_flags & MS_SYNCHRONOUS) || >> >> (fi->flags & CEPH_F_SYNC)) { >> >> mutex_unlock(&inode->i_mutex); >> >> written = ceph_sync_write(file, iov->iov_base, count, >> >>-- >> >>1.8.1.2{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I