From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] i.MX28 AUTO_RESTART, watchdog, battery and poweroff
Date: Wed, 24 Jul 2013 13:40:00 +0200 [thread overview]
Message-ID: <201307241340.00995.marex@denx.de> (raw)
In-Reply-To: <51EFB22B.8080601@digi.com>
Dear Hector Palacios,
> Greetings,
>
> I'm not sure I understand the function mxs_power_clear_auto_restart() in
> spl_power_init.c
We're on the same board there. According to FSL, this is needed on some versions
of MX28 (translation from the techsupp language: we have no idea where this code
came from nor what it does, so we will tell you it's important and you shouldn't
touch it).
I believe the powercode will need a revision and I'll likely get to it once I'm
done with my current hacking.
> The name of the function seems to indicate that its purpose is to *clear*
> the AUTO_RESTART bit, but it is actually setting it:
>
> setbits_le32(&rtc_regs->hw_rtc_persistent0,
> RTC_PERSISTENT0_AUTO_RESTART);
>
> I believe though, that setting this bit is OK because it guarantees that
> the target can be reset from a reset button or a watchdog reset even when
> powered from the battery.
>
> Am I missing something? Otherwise I think this function should be renamed
> to mxs_power_set_auto_restart().
I'd ack the rename. Fabio?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-07-24 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:53 [U-Boot] i.MX28 AUTO_RESTART, watchdog, battery and poweroff Hector Palacios
2013-07-24 11:40 ` Marek Vasut [this message]
2013-07-24 11:46 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307241340.00995.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.