From: Robert Jennings <rcj@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: stable@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Jan Stancek <jstancek@redhat.com>
Subject: Re: [PATCH] powerpc: VPHN topology change updates all siblings
Date: Wed, 24 Jul 2013 09:59:29 -0500 [thread overview]
Message-ID: <20130724145929.GA13737@linux.vnet.ibm.com> (raw)
In-Reply-To: <1374641175.3916.111.camel@pasglop>
* Benjamin Herrenschmidt (benh@kernel.crashing.org) wrote:
> On Tue, 2013-07-23 at 07:33 -0500, Robert Jennings wrote:
> > When an associativity level change is found for one thread, the
> > siblings threads need to be updated as well. This is done today
> > for PRRN in stage_topology_update() but is missing for VPHN in
> > update_cpu_associativity_changes_mask().
> >
> > All threads should be updated to move to the new node. Without this
> > patch, a single thread may be flagged for a topology change, leaving it
> > in a different node from its siblings, which is incorrect. This causes
> > problems for the scheduler where overlapping scheduler groups are created
> > and a loop is formed in those groups.
> >
> > Reported-by: Jan Stancek <jstancek@redhat.com>
> > Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
> > Cc: <stable@vger.kernel.org>
>
> Patch breaks the UP build ...
>
> Cheers,
> Ben.
Very sorry about that, a fix is on the way.
prev parent reply other threads:[~2013-07-24 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 12:33 [PATCH] powerpc: VPHN topology change updates all siblings Robert Jennings
2013-07-24 4:46 ` Benjamin Herrenschmidt
2013-07-24 14:59 ` Robert Jennings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724145929.GA13737@linux.vnet.ibm.com \
--to=rcj@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=jstancek@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.