From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V23Oe-00070H-2Z for qemu-devel@nongnu.org; Wed, 24 Jul 2013 14:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V23Ob-0004QD-Ij for qemu-devel@nongnu.org; Wed, 24 Jul 2013 14:02:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V23Ob-0004Pl-Az for qemu-devel@nongnu.org; Wed, 24 Jul 2013 14:02:41 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6OI2en3003151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Jul 2013 14:02:40 -0400 Date: Wed, 24 Jul 2013 11:02:37 -0700 From: Ian Main Message-ID: <20130724180237.GE2744@gate.mains.priv> References: <1374530960-22031-1-git-send-email-imain@redhat.com> <1374530960-22031-3-git-send-email-imain@redhat.com> <20130724111918.GB3623@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130724111918.GB3623@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Wed, Jul 24, 2013 at 01:19:18PM +0200, Kevin Wolf wrote: > Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > > This patch adds tests for sync modes top and none. Also added are tests > > for invalid and missing formats. > > > > Signed-off-by: Ian Main > > --- > > tests/qemu-iotests/055 | 108 +++++++++++++++++++++++++++++++++++++----- > > tests/qemu-iotests/055.out | 4 +- > > tests/qemu-iotests/group | 2 +- > > tests/qemu-iotests/iotests.py | 5 ++ > > 4 files changed, 103 insertions(+), 16 deletions(-) > > > @@ -127,7 +202,8 @@ class TestSetSpeed(iotests.QMPTestCase): > > self.assert_qmp(result, 'return[0]/device', 'drive0') > > self.assert_qmp(result, 'return[0]/speed', 0) > > > > - result = self.vm.qmp('block-job-set-speed', device='drive0', speed=8 * 1024 * 1024) > > + result = self.vm.qmp('block-job-set-speed', device='drive0', > > + speed=8 * 1024 * 1024) > > Forgot adding sync? Sync defaults to FULL which I think is intended here. IIRC it was just a long line fix. > > self.assert_qmp(result, 'return', {}) > > > > # Ensure the speed we set was accepted > > > @@ -285,4 +367,4 @@ class TestSingleTransaction(iotests.QMPTestCase): > > self.assert_no_active_block_jobs() > > > > if __name__ == '__main__': > > - iotests.main(supported_fmts=['raw', 'qcow2']) > > + iotests.main(supported_fmts=['qcow2', 'qed']) > > Not good. Can we split the test in a part that can be run by raw, and a > separate part that uses backing files? If that is what is needed, sure. Ian > Kevin