All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Rich, Jason" <jason.rich@tekcomms.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Stoltenberg, Matthew" <matthew.stoltenberg@tekcomms.com>,
	James.Bottomley@suse.de
Subject: Re: Panic at _blk_run_queue on 2.6.32
Date: Wed, 24 Jul 2013 23:55:15 +0200	[thread overview]
Message-ID: <20130724215515.GA31938@1wt.eu> (raw)
In-Reply-To: <20130724214847.GA31914@1wt.eu>

Jason,

> Thanks to you first. I'll look for any potentially missing patch after
> this one in newer kernels and will keep you informed. If I can't find
> anything, I'll need James' advice on the subject, and maybe we'll need
> more information about your setup, etc...
> 
> > 0ccd644ce6a803b4f7ae5b3b4da614b8a51037cc is the first bad commit
> > commit 0ccd644ce6a803b4f7ae5b3b4da614b8a51037cc
> > Author: James Bottomley <James.Bottomley@suse.de>
> > Date:   Fri Apr 22 10:39:59 2011 -0500
> >     put stricter guards on queue dead checks
> >     
> >     commit 86cbfb5607d4b81b1a993ff689bbd2addd5d3a9b upstream.

(...)

I just found this patch from James which got merged in 2.6.39 and
backported to 2.6.32 which was merged into 2.6.32.40 :

commit c055f5b2614b4f758ae6cc86733f31fa4c2c5844
Author: James Bottomley <James.Bottomley@suse.de>
Date:   Sun May 1 09:42:07 2011 -0500

    [SCSI] fix oops in scsi_run_queue()
    
    The recent commit closing the race window in device teardown:
    
    commit 86cbfb5607d4b81b1a993ff689bbd2addd5d3a9b
    Author: James Bottomley <James.Bottomley@suse.de>
    Date:   Fri Apr 22 10:39:59 2011 -0500
    
        [SCSI] put stricter guards on queue dead checks
    
    is causing a potential NULL deref in scsi_run_queue() because the
    q->queuedata may already be NULL by the time this function is called.
    Since we shouldn't be running a queue that is being torn down, simply
    add a NULL check in scsi_run_queue() to forestall this.
    
    Tested-by: Jim Schutt <jaschut@sandia.gov>
    Cc: stable@kernel.org
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>

So it is possible that your bisection stopped on the first bug which hides
the real one, but this one was fixed in your faulty kernel. I suggest that
you retry on 2.6.32.40 alone, and if it works, then bisect again between
40 and 42 (which I seem to remember was the first faulty one).

Best regards,
Willy


  reply	other threads:[~2013-07-24 21:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 17:42 Panic at _blk_run_queue on 2.6.32 Rich, Jason
2013-07-10 20:27 ` Willy Tarreau
2013-07-15 14:09   ` Rich, Jason
2013-07-19 14:38     ` Rich, Jason
2013-07-22  9:03       ` Willy Tarreau
2013-07-22 21:15         ` Rich, Jason
2013-07-24 21:29           ` Rich, Jason
2013-07-24 21:48             ` Willy Tarreau
2013-07-24 21:55               ` Willy Tarreau [this message]
2013-09-10 18:04   ` Rich, Jason
2013-09-10 19:15     ` Willy Tarreau
2013-09-10 20:45   ` Rich, Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724215515.GA31938@1wt.eu \
    --to=w@1wt.eu \
    --cc=James.Bottomley@suse.de \
    --cc=jason.rich@tekcomms.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.stoltenberg@tekcomms.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.