From: Lee Jones <lee.jones@linaro.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Subject: Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.
Date: Thu, 25 Jul 2013 09:04:43 +0100 [thread overview]
Message-ID: <20130725080443.GB3403@laptop> (raw)
In-Reply-To: <1374683683-13370-2-git-send-email-p.zabel@pengutronix.de>
On Wed, 24 Jul 2013, Philipp Zabel wrote:
> From: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
>
> This is MFD module providing access to registers and interrupts of DA906x
> series PMIC. It is used by other functional modules, registered as MFD cells.
> Driver uses regmap with paging to access extended register list. Register map
> is divided into two pages, where the second page is used during initialisation.
>
> This module provides support to following functional cells:
> - Regulators
> - RTC
> - HWMON
> - OnKey (power key misc input device)
> - Vibration (force-feedback input device)
> - Watchdog
> - LEDs
>
> Signed-off-by: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/mfd/Kconfig | 12 +
> drivers/mfd/Makefile | 3 +
> drivers/mfd/da9063-core.c | 177 ++++++
> drivers/mfd/da9063-i2c.c | 197 ++++++
> drivers/mfd/da9063-irq.c | 193 ++++++
> include/linux/mfd/da9063/core.h | 110 ++++
> include/linux/mfd/da9063/pdata.h | 114 ++++
> include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++
> 8 files changed, 1896 insertions(+)
Whoah!! Who's going to want to review a 2k line patch?
Any chance you can split this stuff up into more 'bite sized' patches?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-07-25 8:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 16:34 [PATCH 0/2] Add Dialog DA9063 core and regulator drivers Philipp Zabel
2013-07-24 16:34 ` [PATCH 1/2] mfd: Add Dialog DA9063 core driver Philipp Zabel
2013-07-24 17:07 ` Mark Brown
2013-07-25 11:00 ` Philipp Zabel
2013-07-25 8:04 ` Lee Jones [this message]
2013-07-25 8:08 ` Lee Jones
2013-07-25 17:34 ` Philipp Zabel
2013-07-25 18:00 ` Mark Brown
2013-07-29 15:46 ` Lee Jones
2013-07-29 15:57 ` Samuel Ortiz
2013-07-29 15:57 ` Philipp Zabel
2013-07-24 16:34 ` [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support Philipp Zabel
2013-07-24 17:29 ` Mark Brown
2013-07-25 17:35 ` Philipp Zabel
2013-07-25 18:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725080443.GB3403@laptop \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=krystian.garbaciak@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.