All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features
Date: Thu, 25 Jul 2013 20:08:22 +0800	[thread overview]
Message-ID: <20130725120822.GA14010@T430s.redhat.com> (raw)
In-Reply-To: <1374596968-20181-1-git-send-email-benoit@irqsave.net>

On Tue, 07/23 18:29, Benoît Canet wrote:
> The first patch fixes the throttling which was broken by a previous commit.
> 
> The next patch replace the existing throttling algorithm by the well described
> leaky bucket algorithm.
> 
> Third patch implement bursting by adding *_threshold parameters to
> qmp_block_set_io_throttle.
> 
> The last one allow to define the max size of an io when throttling by iops via
> iops_sector_count to avoid vm users cheating on the iops limit.
> 
> The last patch adds a metric reflecting how much the I/O are throttled.
> 
My ignorant question: Besides the fix, how is io throttling improved
from previously, what are the advantages of leaky bucket algorithm?

Thanks.

Fam

  parent reply	other threads:[~2013-07-25 12:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 16:29 [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features Benoît Canet
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code Benoît Canet
2013-07-26 19:16   ` Eric Blake
2013-07-26 19:42     ` Alex Bligh
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm Benoît Canet
2013-07-26  3:40   ` Fam Zheng
2013-07-26  9:48     ` Benoît Canet
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line Benoît Canet
2013-07-26  3:07   ` Fam Zheng
2013-07-26 19:24   ` Eric Blake
2013-07-26 20:55     ` Benoît Canet
2013-08-08 13:37     ` Benoît Canet
2013-08-09  7:09       ` Kevin Wolf
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 4/5] block: Add iops_sector_count to do the iops accounting for a given io size Benoît Canet
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 5/5] block: Add throttling percentage metrics Benoît Canet
2013-07-26  2:55   ` Fam Zheng
2013-07-26  9:49     ` Benoît Canet
2013-07-25 12:08 ` Fam Zheng [this message]
2013-07-25 12:16   ` [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features Benoît Canet
2013-07-26 19:07 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130725120822.GA14010@T430s.redhat.com \
    --to=famz@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.