From: Vinod Koul <vinod.koul@intel.com>
To: David Henningsson <david.henningsson@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.jf.intel.com
Subject: Re: RFC: support for 12 & 24Khz
Date: Thu, 25 Jul 2013 21:02:42 +0530 [thread overview]
Message-ID: <20130725153242.GM18642@intel.com> (raw)
In-Reply-To: <51F0C97B.6040307@canonical.com>
On Thu, Jul 25, 2013 at 08:45:15AM +0200, David Henningsson wrote:
> On 07/24/2013 07:26 PM, Vinod Koul wrote:
> >Hey Takashi,
> >
> >For compressed audio we also need to support the PCM rates of 12 and 24KHz.
> >
> >Looking at pcm.h these are not defined so we can simply add them at the end.
> >But am worried about wider impact of adding these rates.
> >
> >Can you let me know if more is required to be done or below is fine
> >
> >diff --git a/include/sound/pcm.h b/include/sound/pcm.h
> >index 84b10f9..e418d8d 100644
> >--- a/include/sound/pcm.h
> >+++ b/include/sound/pcm.h
> >@@ -126,6 +126,8 @@ struct snd_pcm_ops {
> > #define SNDRV_PCM_RATE_96000 (1<<10) /* 96000Hz */
> > #define SNDRV_PCM_RATE_176400 (1<<11) /* 176400Hz */
> > #define SNDRV_PCM_RATE_192000 (1<<12) /* 192000Hz */
> >+#define SNDRV_PCM_RATE_12000 <1<<13> /* 12000Hz */
> >+#define SNDRV_PCM_RATE_24000 <1<<14> /* 24000Hz */
>
> You probably meant (1<<13), not <1<<13> ?
Yup :)
~Vinod
next prev parent reply other threads:[~2013-07-25 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 17:26 RFC: support for 12 & 24Khz Vinod Koul
2013-07-25 6:45 ` David Henningsson
2013-07-25 15:32 ` Vinod Koul [this message]
2013-07-25 6:50 ` Clemens Ladisch
2013-07-25 15:45 ` Vinod Koul
2013-07-25 16:31 ` Takashi Iwai
2013-07-26 6:09 ` Vinod Koul
2013-07-26 7:09 ` Takashi Iwai
2013-07-28 12:24 ` Vinod Koul
2013-07-25 19:36 ` Mark Brown
2013-07-26 6:11 ` Vinod Koul
2013-07-26 7:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725153242.GM18642@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=pierre-louis.bossart@linux.jf.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.