From: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
To: netdev@vger.kernel.org
Subject: Re: [PATCH] fib_rules: add minimum prefix length
Date: Thu, 25 Jul 2013 18:29:32 +0200 [thread overview]
Message-ID: <20130725162931.GX10216@zirkel.wertarbyte.de> (raw)
In-Reply-To: <20130724021420.GA10670@order.stressinduktion.org>
Dies schrieb Hannes Frederic Sowa (hannes@stressinduktion.org):
> I would try to factor the prefixlen_min check out into a
> e.g. fib4_rule_constrain function for which a new field in fib_rules_ops
> needs to be created as callback. Also it would be nice to have IPv6
> support, too. ;)
I was working on my patchset again and considered your suggestion; however I'm
not sure whether factoring out the constraints into a separate function is
actually that useful, since they are only called from one specific location for
each protocol; can you think of another useful application?
I however did like the idea of adding IPv6 support, so I did -
I'll post the new patch later on.
Thanks for your feedback.
next prev parent reply other threads:[~2013-07-25 16:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 22:02 [PATCH] fib_rules: add minimum prefix length Stefan Tomanek
2013-07-23 22:38 ` Stephen Hemminger
2013-07-23 22:52 ` Stefan Tomanek
2013-07-24 2:14 ` Hannes Frederic Sowa
2013-07-24 7:57 ` Stefan Tomanek
2013-07-25 16:29 ` Stefan Tomanek [this message]
2013-07-25 17:43 ` [PATCH] fib_rules/fib6rules: " Stefan Tomanek
2013-07-25 18:17 ` [PATCH] fib_rules: " Hannes Frederic Sowa
2013-07-25 18:28 ` Stefan Tomanek
2013-07-25 21:46 ` Andrew Collins
2013-07-25 22:11 ` Stefan Tomanek
2013-07-26 10:46 ` [PATCH] fib_rules: add .suppress operation Stefan Tomanek
2013-07-26 17:05 ` Hannes Frederic Sowa
2013-07-27 6:08 ` Hannes Frederic Sowa
2013-07-27 6:26 ` Hannes Frederic Sowa
2013-07-27 7:07 ` Hannes Frederic Sowa
2013-07-27 10:21 ` Stefan Tomanek
2013-07-27 15:10 ` Hannes Frederic Sowa
2013-07-28 10:36 ` Stefan Tomanek
2013-07-30 6:52 ` [PATCH v2 1/2] fib6_rules: make error handling consistent with IPv4 Stefan Tomanek
2013-07-30 6:53 ` [PATCH v2 2/2] fib_rules: add .suppress operation Stefan Tomanek
2013-07-30 7:03 ` David Miller
2013-07-30 7:23 ` Stefan Tomanek
2013-07-30 7:34 ` David Miller
2013-07-30 7:46 ` [PATCH v3] " Stefan Tomanek
2013-07-31 22:13 ` David Miller
2013-08-01 0:24 ` Stefan Tomanek
2013-08-01 0:26 ` David Miller
2013-08-01 0:17 ` [PATCH v4] " Stefan Tomanek
2013-08-01 0:27 ` David Miller
2013-08-01 1:26 ` Stefan Tomanek
2013-08-01 5:35 ` Hannes Frederic Sowa
2013-07-26 10:54 ` [PATCH] fib_rules: add minimum prefix length Stefan Tomanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725162931.GX10216@zirkel.wertarbyte.de \
--to=stefan.tomanek@wertarbyte.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.