From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET Date: Thu, 25 Jul 2013 19:40:17 +0300 Message-ID: <20130725164016.GA4027@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id 402B126084C for ; Thu, 25 Jul 2013 18:40:57 +0200 (CEST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen , Daniel Mack Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, Liam Girdwood , Rob Herring , Mark Brown , device-drivers-devel@blackfin.uclinux.org, Grant Likely List-Id: alsa-devel@alsa-project.org ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and not an unsigned long. The current tests are always false. Signed-off-by: Dan Carpenter diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 44d8a95..2c10252 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -91,7 +91,7 @@ #define ADAU1701_OSCIPOW_OPD 0x04 #define ADAU1701_DACSET_DACINIT 1 -#define ADAU1707_CLKDIV_UNSET (-1UL) +#define ADAU1707_CLKDIV_UNSET (-1U) #define ADAU1701_FIRMWARE "adau1701.bin" From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 25 Jul 2013 16:40:17 +0000 Subject: [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET Message-Id: <20130725164016.GA4027@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lars-Peter Clausen , Daniel Mack Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, Liam Girdwood , Rob Herring , Mark Brown , device-drivers-devel@blackfin.uclinux.org, Grant Likely ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and not an unsigned long. The current tests are always false. Signed-off-by: Dan Carpenter diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 44d8a95..2c10252 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -91,7 +91,7 @@ #define ADAU1701_OSCIPOW_OPD 0x04 #define ADAU1701_DACSET_DACINIT 1 -#define ADAU1707_CLKDIV_UNSET (-1UL) +#define ADAU1707_CLKDIV_UNSET (-1U) #define ADAU1701_FIRMWARE "adau1701.bin" From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:44138 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755970Ab3GYQmZ (ORCPT ); Thu, 25 Jul 2013 12:42:25 -0400 Date: Thu, 25 Jul 2013 19:40:17 +0300 From: Dan Carpenter Subject: [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET Message-ID: <20130725164016.GA4027@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: devicetree-owner@vger.kernel.org To: Lars-Peter Clausen , Daniel Mack Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Grant Likely , Rob Herring , device-drivers-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and not an unsigned long. The current tests are always false. Signed-off-by: Dan Carpenter diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 44d8a95..2c10252 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -91,7 +91,7 @@ #define ADAU1701_OSCIPOW_OPD 0x04 #define ADAU1701_DACSET_DACINIT 1 -#define ADAU1707_CLKDIV_UNSET (-1UL) +#define ADAU1707_CLKDIV_UNSET (-1U) #define ADAU1701_FIRMWARE "adau1701.bin"