From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg KH <greg@kroah.com>
Subject: Re: [RFC/PATCH 2/2] usb: ehci: Add support for
 SINGLE_STEP_SET_FEATURE test of EHSET
Date: Thu, 25 Jul 2013 11:46:51 -0700
Message-ID: <20130725184651.GA15259@kroah.com>
References: <1591113.JYQdTBbFW7@dabox>
 <1372821232-7196-1-git-send-email-jackp@codeaurora.org>
 <1372821232-7196-3-git-send-email-jackp@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33947 "EHLO
	out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756279Ab3GYSqx (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Thu, 25 Jul 2013 14:46:53 -0400
Content-Disposition: inline
In-Reply-To: <1372821232-7196-3-git-send-email-jackp@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Jack Pham <jackp@codeaurora.org>
Cc: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org, Tim Sander <tim@krieglstein.org>, Manu Gautam <mgautam@codeaurora.org>, linux-arm-msm@vger.kernel.org

On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote:
> From: Manu Gautam <mgautam@codeaurora.org>
> 
> The USB Embedded High-speed Host Electrical Test (EHSET) defines the
> SINGLE_STEP_SET_FEATURE test as follows:
> 
> 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108
> 2) The host sends the SETUP stage of a GetDescriptor(Device)
> 3) The device ACKs the request
> 4) The host issues SOFs for 15 seconds allowing the test operator to
>    raise the scope trigger just above the SOF voltage level
> 5) The host sends the IN packet
> 6) The device sends data in response, triggering the scope
> 7) The host sends an ACK in response to the data
> 
> This patch adds additional handling to the EHCI hub driver and allows
> the EHSET driver to initiate this test mode by issuing a a SetFeature
> request to the root hub with a Test Selector value of 0x06. From there
> it mimics ehci_urb_enqueue() but separately submits QTDs for the
> SETUP and DATA/STATUS stages in order to insert a delay in between.
> 
> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
> Signed-off-by: Jack Pham <jackp@codeaurora.org>

Alan, any thoughts about this patch?

thanks,

greg k-h