From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Pham Subject: Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET Date: Thu, 25 Jul 2013 15:09:25 -0700 Message-ID: <20130725220925.GA28634@usblab-sd-06.qualcomm.com> References: <1591113.JYQdTBbFW7@dabox> <1372821232-7196-1-git-send-email-jackp@codeaurora.org> <1372821232-7196-3-git-send-email-jackp@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:42596 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881Ab3GYWJb (ORCPT ); Thu, 25 Jul 2013 18:09:31 -0400 Content-Disposition: inline In-Reply-To: <1372821232-7196-3-git-send-email-jackp@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Alan Stern , Greg KH , linux-usb@vger.kernel.org Cc: Tim Sander , Manu Gautam , linux-arm-msm@vger.kernel.org On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > SINGLE_STEP_SET_FEATURE test as follows: > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c > index 2b70277..8e6dc09 100644 > --- a/drivers/usb/host/ehci-hub.c > +++ b/drivers/usb/host/ehci-hub.c > +static int ehset_single_step_set_feature(struct usb_hcd *hcd, int port) > +{ > + int retval = -ENOMEM; > + struct usb_ctrlrequest *dr; > + struct urb *urb; > + struct usb_device *udev; > + struct ehci_hcd *ehci = hcd_to_ehci(hcd); > + struct usb_device_descriptor *buf; > + DECLARE_COMPLETION_ONSTACK(done); > + > + /* Obtain udev of the rhub's child port */ > + udev = hcd->self.root_hub->children[port]; Oops, I forgot to add this additional fix needed after refreshing to latest: - udev = hcd->self.root_hub->children[port]; + udev = usb_hub_find_child(hcd->self.root_hub, port); I'll wait for Felipe's response regarding whether it's appropriate to do this in the HCD, and then will re-send without the RFC tag. Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation