From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qom-next for-1.6 13/14] xilinx_uartlite: Rename xlx_uartlite to XilinxUARTLite
Date: Fri, 26 Jul 2013 05:05:09 +0200 [thread overview]
Message-ID: <20130726030509.GF25811@smtp.vpn> (raw)
In-Reply-To: <1374702140-13771-14-git-send-email-afaerber@suse.de>
On Wed, Jul 24, 2013 at 11:42:18PM +0200, Andreas Färber wrote:
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> ---
> hw/char/xilinx_uartlite.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c
> index feca497..929743c 100644
> --- a/hw/char/xilinx_uartlite.c
> +++ b/hw/char/xilinx_uartlite.c
> @@ -46,8 +46,7 @@
> #define CONTROL_RST_RX 0x02
> #define CONTROL_IE 0x10
>
> -struct xlx_uartlite
> -{
> +typedef struct XilinxUARTLite {
> SysBusDevice busdev;
> MemoryRegion mmio;
> CharDriverState *chr;
> @@ -58,9 +57,9 @@ struct xlx_uartlite
> unsigned int rx_fifo_len;
>
> uint32_t regs[R_MAX];
> -};
> +} XilinxUARTLite;
>
> -static void uart_update_irq(struct xlx_uartlite *s)
> +static void uart_update_irq(XilinxUARTLite *s)
> {
> unsigned int irq;
>
> @@ -71,7 +70,7 @@ static void uart_update_irq(struct xlx_uartlite *s)
> qemu_set_irq(s->irq, irq);
> }
>
> -static void uart_update_status(struct xlx_uartlite *s)
> +static void uart_update_status(XilinxUARTLite *s)
> {
> uint32_t r;
>
> @@ -86,7 +85,7 @@ static void uart_update_status(struct xlx_uartlite *s)
> static uint64_t
> uart_read(void *opaque, hwaddr addr, unsigned int size)
> {
> - struct xlx_uartlite *s = opaque;
> + XilinxUARTLite *s = opaque;
> uint32_t r = 0;
> addr >>= 2;
> switch (addr)
> @@ -113,7 +112,7 @@ static void
> uart_write(void *opaque, hwaddr addr,
> uint64_t val64, unsigned int size)
> {
> - struct xlx_uartlite *s = opaque;
> + XilinxUARTLite *s = opaque;
> uint32_t value = val64;
> unsigned char ch = value;
>
> @@ -164,7 +163,7 @@ static const MemoryRegionOps uart_ops = {
>
> static void uart_rx(void *opaque, const uint8_t *buf, int size)
> {
> - struct xlx_uartlite *s = opaque;
> + XilinxUARTLite *s = opaque;
>
> /* Got a byte. */
> if (s->rx_fifo_len >= 8) {
> @@ -182,7 +181,7 @@ static void uart_rx(void *opaque, const uint8_t *buf, int size)
>
> static int uart_can_rx(void *opaque)
> {
> - struct xlx_uartlite *s = opaque;
> + XilinxUARTLite *s = opaque;
>
> return s->rx_fifo_len < sizeof(s->rx_fifo);
> }
> @@ -194,7 +193,7 @@ static void uart_event(void *opaque, int event)
>
> static int xilinx_uartlite_init(SysBusDevice *dev)
> {
> - struct xlx_uartlite *s = FROM_SYSBUS(typeof (*s), dev);
> + XilinxUARTLite *s = FROM_SYSBUS(typeof (*s), dev);
>
> sysbus_init_irq(dev, &s->irq);
>
> @@ -219,7 +218,7 @@ static void xilinx_uartlite_class_init(ObjectClass *klass, void *data)
> static const TypeInfo xilinx_uartlite_info = {
> .name = "xlnx.xps-uartlite",
> .parent = TYPE_SYS_BUS_DEVICE,
> - .instance_size = sizeof (struct xlx_uartlite),
> + .instance_size = sizeof(XilinxUARTLite),
> .class_init = xilinx_uartlite_class_init,
> };
>
> --
> 1.8.1.4
>
next prev parent reply other threads:[~2013-07-26 3:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 21:42 [Qemu-devel] [PATCH qom-next for-1.6 00/14] char: QOM cast cleanups Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 01/14] cadence_uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 02/14] escc: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 03/14] etraxfs_ser: QOM'ify Andreas Färber
2013-07-26 3:04 ` Edgar E. Iglesias
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 04/14] exynos4210_uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 05/14] grlib_apbuart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_serial: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 07/14] lm32_juart: Relocate and tidy header Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 08/14] lm32_juart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 09/14] lm32_uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 10/14] milkymist-uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 11/14] pl011: Rename pl011_state Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 12/14] pl011: QOM'ify pl011 and pl011_luminary Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 13/14] xilinx_uartlite: Rename xlx_uartlite to XilinxUARTLite Andreas Färber
2013-07-26 3:05 ` Edgar E. Iglesias [this message]
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 14/14] xilinx_uartlite: QOM'ify Andreas Färber
2013-07-26 3:05 ` Edgar E. Iglesias
2013-07-26 22:28 ` [Qemu-devel] [PATCH qom-next for-1.6 00/14] char: QOM cast cleanups Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726030509.GF25811@smtp.vpn \
--to=edgar.iglesias@gmail.com \
--cc=afaerber@suse.de \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.