From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: Maintainer-review fluff (was: Re: [PATCH 01/12] drm/i915: plumb VM into object operations) Date: Fri, 26 Jul 2013 10:12:43 -0700 Message-ID: <20130726101243.6a0d1915@jbarnes-desktop> References: <1374458899-8635-1-git-send-email-ben@bwidawsk.net> <1374458899-8635-2-git-send-email-ben@bwidawsk.net> <20130726095100.GB6084@phenom.ffwll.local> <20130726095942.17b82949@jbarnes-desktop> <20130726170848.GA3132@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 93838E7565 for ; Fri, 26 Jul 2013 10:12:32 -0700 (PDT) In-Reply-To: <20130726170848.GA3132@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Fri, 26 Jul 2013 18:08:48 +0100 Chris Wilson wrote: > On Fri, Jul 26, 2013 at 09:59:42AM -0700, Jesse Barnes wrote: > > 4) review comments should be concrete and actionable, and ideally not > > leave the author hanging with hints about problems the reviewer > > has spotted, leaving the author looking for easter eggs > > Where am I going to find my fun, if I am not allowed to tell you that > you missed a zero in a thousand line patch but not tell you where? > Spoilsport :-p You'll just need to take up golf or something. :) -- Jesse Barnes, Intel Open Source Technology Center