All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Ping Fan Liu <pingfank@linux.vnet.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>,
	alex@alex.org.uk
Subject: Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()
Date: Fri, 26 Jul 2013 12:36:43 -0400	[thread overview]
Message-ID: <20130726163643.GD19811@localhost.localdomain> (raw)
In-Reply-To: <51F2A2EE.5040403@redhat.com>

On Fri, Jul 26, 2013 at 06:25:18PM +0200, Paolo Bonzini wrote:
> Il 26/07/2013 18:10, Jeff Cody ha scritto:
> > +   /* wait until next event that is not aio_notify() */
> > +   while (count > 1) {
> > 
> > This would assume of course that aio_notify() is always first in the
> > list.
> 
> No, you cannot assume that.  Any bdrv can be opened early (with -drive)
> and then associated to an AioContext that is created later (when the
> dataplane thread start).
> 
> Paolo
>

OK, good point, thanks.

Jeff

  reply	other threads:[~2013-07-26 16:37 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 15:18 [Qemu-devel] [PATCH v6 00/18] aio: drop io_flush() Stefan Hajnoczi
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete() Stefan Hajnoczi
2013-07-26  6:43   ` Wenchao Xia
2013-08-06 15:06     ` Stefan Hajnoczi
2013-08-07  2:42       ` Wenchao Xia
2013-08-07  7:31         ` Stefan Hajnoczi
2013-08-07  7:42   ` Stefan Hajnoczi
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 02/18] block: stop relying on io_flush() in bdrv_drain_all() Stefan Hajnoczi
2013-07-29  7:01   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 03/18] dataplane/virtio-blk: check exit conditions before aio_poll() Stefan Hajnoczi
2013-07-26 16:44   ` Jeff Cody
2013-07-29  7:10   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 04/18] tests: adjust test-aio to new aio_poll() semantics Stefan Hajnoczi
2013-07-29  7:39   ` Wenchao Xia
2013-07-29  8:24   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 05/18] tests: adjust test-thread-pool " Stefan Hajnoczi
2013-07-29  7:51   ` Wenchao Xia
2013-07-29 14:26     ` Stefan Hajnoczi
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush() Stefan Hajnoczi
2013-07-26 16:10   ` Jeff Cody
2013-07-26 16:25     ` Paolo Bonzini
2013-07-26 16:36       ` Jeff Cody [this message]
2013-07-26 16:43   ` Jeff Cody
2013-07-29  8:08   ` Wenchao Xia
2013-07-29 14:32     ` Stefan Hajnoczi
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 07/18] block/curl: drop curl_aio_flush() Stefan Hajnoczi
2013-07-29  8:11   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 08/18] block/gluster: drop qemu_gluster_aio_flush_cb() Stefan Hajnoczi
2013-07-29  8:17   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 09/18] block/iscsi: drop iscsi_process_flush() Stefan Hajnoczi
2013-07-29  8:17   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 10/18] block/linux-aio: drop qemu_laio_completion_cb() Stefan Hajnoczi
2013-07-29  8:19   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 11/18] block/nbd: drop nbd_have_request() Stefan Hajnoczi
2013-07-29  8:19   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 12/18] block/rbd: drop qemu_rbd_aio_flush_cb() Stefan Hajnoczi
2013-07-29  8:20   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 13/18] block/sheepdog: drop have_co_req() and aio_flush_request() Stefan Hajnoczi
2013-07-26  5:50   ` MORITA Kazutaka
2013-07-29  8:24   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 14/18] block/ssh: drop return_true() Stefan Hajnoczi
2013-07-29  8:25   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 15/18] dataplane/virtio-blk: drop flush_true() and flush_io() Stefan Hajnoczi
2013-07-29  8:32   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 16/18] thread-pool: drop thread_pool_active() Stefan Hajnoczi
2013-07-29  8:33   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 17/18] tests: drop event_active_cb() Stefan Hajnoczi
2013-07-29  8:34   ` Wenchao Xia
2013-07-25 15:18 ` [Qemu-devel] [PATCH v6 18/18] aio: drop io_flush argument Stefan Hajnoczi
2013-07-29  8:37   ` Wenchao Xia
2013-08-06 15:07 ` [Qemu-devel] [PATCH v6 00/18] aio: drop io_flush() Stefan Hajnoczi
2013-08-09  7:14   ` Wenchao Xia
2013-08-09  8:31     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130726163643.GD19811@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=alex@alex.org.uk \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=pingfank@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.