From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Retry DP aux_ch communications with a different clock after failure Date: Fri, 26 Jul 2013 19:45:46 +0200 Message-ID: <20130726174546.GF6084@phenom.ffwll.local> References: <1374418803-24914-1-git-send-email-chris@chris-wilson.co.uk> <87k3kd5z3i.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id DA967E7575 for ; Fri, 26 Jul 2013 10:45:47 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id d51so250058eek.37 for ; Fri, 26 Jul 2013 10:45:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87k3kd5z3i.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 26, 2013 at 02:40:01PM +0300, Jani Nikula wrote: > On Sun, 21 Jul 2013, Chris Wilson wrote: > > The w/a db makes the recommendation to both use a non-default value for > > the initial clock and then to retry with an alternative clock for > > Haswell with the Lakeport PCH. > > > > "On LPT:H, use a divider value of 63 decimal (03Fh). If there is a > > failure, retry at least three times with 63, then retry at least three > > times with 72 decimal (048h)." > > Overall I'd prefer adding the outer repeat loop first, keeping existing > behaviour, and only then adding the divider value changes in > get_aux_clock_divider(). But that's in the bikeshedding dept. Either > way, > > Reviewed-by: Jani Nikula Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch