From: Gleb Natapov <gleb@redhat.com>
To: Arthur Chunqi Li <yzt356@gmail.com>
Cc: kvm <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@web.de>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] kvm-unit-tests : Basic architecture of VMX nested test case
Date: Sun, 28 Jul 2013 15:24:08 +0300 [thread overview]
Message-ID: <20130728122408.GH11772@redhat.com> (raw)
In-Reply-To: <CABpY8MKU640S7Pk83pSiMBFYx5=n=kjfx=uFcAwnjARDfot8FA@mail.gmail.com>
On Sun, Jul 28, 2013 at 08:18:25PM +0800, Arthur Chunqi Li wrote:
> >> +
> >> +#define SEL_NULL_DESC 0x0
> >> +#define SEL_KERN_CODE_64 0x8
> >> +#define SEL_KERN_DATA_64 0x10
> >> +#define SEL_USER_CODE_64 0x18
> >> +#define SEL_USER_DATA_64 0x20
> >> +#define SEL_CODE_32 0x28
> >> +#define SEL_DATA_32 0x30
> >> +#define SEL_CODE_16 0x38
> >> +#define SEL_DATA_16 0x40
> >> +#define SEL_TSS_RUN 0x48
> >> +
> > This need too be move to the common header file.
> Which header file do you think is suitable to contain these selector
> defines? It should correspond to the defines in x86/cstart64.S
> (x86/cstart.S for 32 bit). lib/x86/processor.h may be suitable, but
> this file only contains inline functions now.
>
They are VM related, so lib/x86/vm.h should be a good place.
--
Gleb.
prev parent reply other threads:[~2013-07-28 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 16:32 [PATCH v2] kvm-unit-tests : Basic architecture of VMX nested test case Arthur Chunqi Li
2013-07-25 16:51 ` Bandan Das
2013-07-25 16:53 ` Jan Kiszka
2013-07-25 17:25 ` Gmail
2013-07-28 10:53 ` Gleb Natapov
2013-07-28 12:18 ` Arthur Chunqi Li
2013-07-28 12:24 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130728122408.GH11772@redhat.com \
--to=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yzt356@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.