From: Greg KH <gregkh@linuxfoundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: lustre: Fix non-ANSI sparse warnings
Date: Sun, 28 Jul 2013 16:43:55 +0000 [thread overview]
Message-ID: <20130728164355.GA8320@kroah.com> (raw)
In-Reply-To: <1374964736-10863-1-git-send-email-emilgoode@gmail.com>
On Sun, Jul 28, 2013 at 06:19:29PM +0200, walter harms wrote:
>
>
> Am 28.07.2013 00:38, schrieb Emil Goode:
> > This patch fixes a lot of non-ANSI sparse warnings by adding void to
> > parameterless functions.
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
> > ---
> > v2: A bit more specific commit message.
> >
> > .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.c | 6 +++---
> > drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
> > drivers/staging/lustre/lnet/selftest/console.c | 2 +-
> > .../staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 14 +++++++-------
> > drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 2 +-
> > drivers/staging/lustre/lustre/ptlrpc/pinger.c | 4 ++--
> > 6 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> > index 3e08fe2..76e442b 100644
> > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> > @@ -325,20 +325,20 @@ ksocknal_lib_tunables_init ()
> > }
> >
> > void
> > -ksocknal_lib_tunables_fini ()
> > +ksocknal_lib_tunables_fini(void)
> > {
> > if (ksocknal_tunables.ksnd_sysctl != NULL)
> > unregister_sysctl_table(ksocknal_tunables.ksnd_sysctl);
> > }
>
> this is not needed as unregister_sysctl_table() can handle NULL
There's lots of cleanup needed in this code, but as that's a separate
thing from what the original poster was doing here, it isn't relevant
for this patch.
Follow-on patches are always welcome...
greg k-h
prev parent reply other threads:[~2013-07-28 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 22:38 [PATCH v2 1/2] staging: lustre: Fix non-ANSI sparse warnings Emil Goode
2013-07-28 16:19 ` walter harms
2013-07-28 16:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130728164355.GA8320@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.